Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130417 --- Ship it! lgtm, just a few nits below. src/main/java/org/apach

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-25 Thread Maxim Khutornenko
> On April 24, 2016, 4:01 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 114 > > > > > > Generalizing all resources to varchar type is quite unfortunate.

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Maxim Khutornenko
> On April 24, 2016, 3:52 p.m., Bill Farner wrote: > > RELEASE-NOTES.md, line 13 > > > > > > Seems prudent to include a warning about MESOS-703 here and in a doc. +1 - Maxim --

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130447 --- Ship it! - Maxim Khutornenko On April 23, 2016, 12:38 a.m., S

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-25 Thread Maxim Khutornenko
> On April 24, 2016, 3:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java, line 51 > > > > > > Does this default value effect the same behavior as before the patch? > >

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Zameer Manji
> On April 24, 2016, 8:52 a.m., Bill Farner wrote: > > RELEASE-NOTES.md, line 13 > > > > > > Seems prudent to include a warning about MESOS-703 here and in a doc. > > Maxim Khutornenko wrote: > +1 +1 It is very

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130468 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:38 p.m

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130506 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:16 p.m

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130507 --- Ship it! Ship It! - Bill Farner On April 22, 2016, 5:16 p.m.

Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'

2016-04-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130510 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 2:54 p.m

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-25 Thread Maxim Khutornenko
> On April 25, 2016, 2:34 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java, > > line 107 > > > > > > Should we pull `ResourceType.findByResource(e)` up to a v

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 25, 2016, 11:18 p.m.) Review request for Aurora, Joshua Cohen, B