Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136403 --- Ship it! Master (2e7b317) is green with this patch.

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/ --- (Updated June 7, 2016, 4:11 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136297 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 246)

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-06 Thread Maxim Khutornenko
> On May 28, 2016, 9:35 p.m., Stephan Erb wrote: > > The refactoring itself looks good. However, I am not sure if we should > > really opt for the metric name change. It will break external statistic > > scrapers without a great benefit for us. Correct, this will require adjusting scheduler

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136350 --- Looks good. A few minor comments left.

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136354 --- Ship it! lgtm, just a couple of style nits.

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/ --- (Updated June 6, 2016, 7:13 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

2016-06-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136351 --- Ship it! Master (d64e179) is green with this patch.

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 6, 2016, 11:13 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 6, 2016, 11:22 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-06-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review136375 --- Ship it! Ship It! - Stephan Erb On June 4, 2016, 8:33 p.m.,

Re: Review Request 47998: Converting resource counters to use new resource fields

2016-06-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review136384 --- Ship it! Master (2e7b317) is green with this patch.