Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/#review139813 --- LGTM, just a few minor changes left.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139819 --- Master (73dd2a8) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139818 --- Fix it, then Ship it!

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 28, 2016, 9:51 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49330: Add announce and enable_hooks to Job Schema table

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49330/#review139822 --- Master (73dd2a8) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139828 --- Ship it! Master (73dd2a8) is green with this patch.

Review Request 49330: Add announce and enable_hooks to Job Schema table

2016-06-28 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49330/ --- Review request for Aurora. Repository: aurora Description --- Add

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
> On June 28, 2016, 10:02 a.m., Aurora ReviewBot wrote: > > Master (73dd2a8) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > src/test/python/apache/thermos/common/test_planner.py::test_planner_empty > > PASSED > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 28, 2016, 10:28 a.m.) Review request for Aurora, Joshua Cohen

Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository:

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/#review139857 --- config/legacy_untested_classes.txt (line 44)

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/#review139932 --- Ship it! Master (102f5f0) is green with this patch.

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
> On June 28, 2016, 1:53 p.m., David McLaughlin wrote: > > config/legacy_untested_classes.txt, line 44 > > > > > > Isn't this a fairly easy class to test? > > Mehrdad Nurolahzade wrote: > I wrote a test for it

Re: Review Request 49339: Update install docs to for Aurora 0.14.0

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49339/#review139874 --- Ship it! Master (499b11b) is green with this patch.

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/ --- (Updated June 28, 2016, 3:04 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/#review139892 --- Ship it! Anyone else wants to review this change? If not I

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 28, 2016, 4:57 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/#review139860 --- Ship it! Master (499b11b) is green with this patch.

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Mehrdad Nurolahzade
> On June 28, 2016, 1:53 p.m., David McLaughlin wrote: > > config/legacy_untested_classes.txt, line 44 > > > > > > Isn't this a fairly easy class to test? I wrote a test for it initially but then I ran into a few

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Renan DelValle
> On June 28, 2016, 9:52 a.m., Maxim Khutornenko wrote: > > LGTM, just a few minor changes left. Thanks for the quick reviews, really appreciate it. > On June 28, 2016, 9:52 a.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 148-152 > >

Review Request 49339: Update install docs to for Aurora 0.14.0

2016-06-28 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49339/ --- Review request for Aurora. Repository: aurora Description --- Update

Re: Review Request 49338: Update packaging for Aurora 0.14

2016-06-28 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49338/#review139871 --- Ship it! Ship It! - John Sirois On June 28, 2016, 3:45

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/#review139893 --- Ship it! Ship It! - Maxim Khutornenko On June 28, 2016,

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/#review139885 --- Ship it! Master (499b11b) is green with this patch.

Review Request 49338: Update packaging for Aurora 0.14

2016-06-28 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49338/ --- Review request for Aurora and John Sirois. Repository: aurora-packaging

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/#review139876 --- Ship it! Master (499b11b) is green with this patch.

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread David McLaughlin
> On June 28, 2016, 8:53 p.m., David McLaughlin wrote: > > config/legacy_untested_classes.txt, line 44 > > > > > > Isn't this a fairly easy class to test? > > Mehrdad Nurolahzade wrote: > I wrote a test for it

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

2016-06-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/#review139888 --- Ship it! Ship It! - David McLaughlin On June 28, 2016,

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139923 --- Ship it! - Joshua Cohen On June 28, 2016, 11:57 p.m.,

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/#review139926 --- Fix it, then Ship it! lgtm modulo the below. Please fix or

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Renan DelValle
> On June 28, 2016, 8:46 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 267 > > > > > > Is there a mesos ticket tracking this? If so, can you add it

Re: Review Request 49218: Add support for Mesos Fetcher

2016-06-28 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49218/ --- (Updated June 28, 2016, 9:36 p.m.) Review request for Aurora. Changes