Re: Review Request 49399: Fix Process log configuration handling.

2016-06-30 Thread Martin Hrabovcin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49399/#review140140 --- Ship it! Nice integration test - Martin Hrabovcin On June 29

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

2016-06-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140155 --- Ship it! Ship It! - Stephan Erb On June 30, 2016, 2:10 a.m.,

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49399/#review140156 --- Your fix looks correct. Also thanks for investing the time for the

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-30 Thread Stephan Erb
> On June 30, 2016, 12:58 a.m., John Sirois wrote: > > src/main/python/apache/thermos/core/runner.py, line 750 > > > > > > NB: The trailing comma here on the LHS formed a 1-tuple leading to the > > initial bug repor

Re: Review Request 49399: Fix Process log configuration handling.

2016-06-30 Thread John Sirois
> On June 30, 2016, 7:39 a.m., Stephan Erb wrote: > > Your fix looks correct. Also thanks for investing the time for the test! > > > > However, I kind of feel that the overall feature is more complicated than > > it should be. Two ideas below, feedback welcome. My thinking is outlined below. A

Review Request 49478: Fixing e2e tests failing due to mesos-slave state.

2016-06-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --

Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.

2016-06-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/#review140267 --- Master (be2174b) is red with this patch. ./build-support/jenkins

Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.

2016-06-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/ --- (Updated June 30, 2016, 11:29 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.

2016-06-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/#review140275 --- Ship it! Master (be2174b) is green with this patch. ./build-s

Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.

2016-06-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/#review140289 --- Ship it! Ship It! - Joshua Cohen On June 30, 2016, 11:29 p.m