Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/#review141625 --- I'm going to patch this in presently on your behalf to eliminate

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/#review141619 --- Master (528198e) is red with this patch.

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread Stephan Erb
> On July 10, 2016, 7:55 p.m., Aurora ReviewBot wrote: > > Master (528198e) is red with this patch. > > ./build-support/jenkins/build.sh > > > >  with temporary_dir() as checkpoint_root: > > te = AuroraExecutor( > >

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread John Sirois
> On July 10, 2016, 3:35 p.m., John Sirois wrote: > > I'm not sure this is directly relevant to the problem at hand. Pants > > bootstraps fine, is the thermos integration tests that pants runs (must be > > bootstrapped via pip to do so), that have a `./pants` subprocess call fail. > > You

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/#review141623 --- Ship it! LGTM. I stole your edits and applied them to the

Re: Review Request 49872: Upgrade pants to 1.1.0-rc7.

2016-07-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49872/#review141626 --- NB: I won't wait on Zameer's review since he may no longer be

Review Request 49872: Upgrade pants to 1.1.0-rc7.

2016-07-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49872/ --- Review request for Aurora, Stephan Erb and Zameer Manji. Repository: aurora

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/ --- (Updated July 10, 2016, 7:38 p.m.) Review request for Aurora and John Sirois.

Re: Review Request 49872: Upgrade pants to 1.1.0-rc7.

2016-07-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49872/#review141628 --- Ship it! Master (c41420f) is green with this patch.

Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/ --- Review request for Aurora and John Sirois. Bugs: AURORA-1717

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/#review141617 --- Master (528198e) is red with this patch.

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread Stephan Erb
> On July 10, 2016, 7:01 p.m., Aurora ReviewBot wrote: > > Master (528198e) is red with this patch. > > ./build-support/jenkins/build.sh > > > > virtualenv-15.0.2/virtualenv_embedded/activate_this.py > > virtualenv-15.0.2/virtualenv_embedded/deactivate.bat > >

Re: Review Request 49868: Update virtualenv version to 15.0.2

2016-07-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/#review141622 --- I'm not sure this is directly relevant to the problem at hand.