Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-15 Thread Mehrdad Nurolahzade
> On July 14, 2016, 7:34 p.m., Joshua Cohen wrote: > > How do you feel about adding a unit test for `getOffers` that verifies all > > this new logic? I feel good. :) > On July 14, 2016, 7:34 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/Offers.java, line 89 > >

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

2016-07-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142443 --- Master (e67c6a7) is red with this patch.

Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage

2016-07-15 Thread George Sirois
> On July 4, 2016, 7:55 a.m., Stephan Erb wrote: > > Have you considered querying Mesos for the disk usage of the task? That > > would be in line with our desire to also leave the isolation up to Mesos > > https://issues.apache.org/jira/browse/AURORA-1033 > > Martin Hrabovcin wrote: > I