Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
> On July 23, 2016, 5:13 p.m., Stephan Erb wrote: > > LGTM! > > > > Minor missing things: > > > > * deprecation notice for the user-facing configuration option > > * rebase > > > > > > Joshua, would be great if you could land this patch once its done. I am > > gone for the week & without pro

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 25, 2016, 8:30 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143386 --- Master (9c316d3) is red with this patch. ./build-support/jenkins

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143387 --- Ship it! Below is not a blocker for me. RELEASE-NOTES.md (lin

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143388 --- @ReviewBot retry - Joshua Cohen On July 25, 2016, 3:30 p.m., Me

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143389 --- Ship it! Master (9c316d3) is green with this patch. ./build-s

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
> On July 25, 2016, 8:55 a.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 20 > > > > > > Given that tier names are configurable by Aurora operators, should we > > word this differently? Better? The job config

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
> On July 25, 2016, 3:55 p.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 20 > > > > > > Given that tier names are configurable by Aurora operators, should we > > word this differently? > > Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 25, 2016, 9:25 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143393 --- Ship it! Ship It! - Joshua Cohen On July 25, 2016, 4:25 p.m.

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review143421 --- api/src/main/thrift/org/apache/aurora/gen/storage.thrift (lines 9

Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-25 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: AURORA

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review143474 --- Master (380307a) is green with this patch. ./build-support/jenki

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review143475 --- Ship it! Ship It! - David McLaughlin On July 26, 2016, 2:36

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review143476 --- Ship it! Ship It! - Maxim Khutornenko On July 26, 2016, 2:36