Re: Review Request 50530: AURORA-1656 Document tier concept

2016-07-28 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50530/#review143958 --- Ship it! Ship It! - Stephan Erb On Juli 28, 2016, 12:41

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
> On July 21, 2016, 4:05 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > lines 279-280 > > > > > > What is the purpose of this call if it's not

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated July 28, 2016, 10:54 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread David McLaughlin
> On July 28, 2016, 8:44 p.m., David McLaughlin wrote: > > For me ROLLED_BACK has a clear meaning - a job that was rolled back due to > > a failed health check in the update process. Overloading like this is going > > to lead to ambiguity and I wouldn't be comfortable exposing this > >

Re: Review Request 50480: Multiple executor support in Scheduler

2016-07-28 Thread Renan DelValle
> On July 26, 2016, 8:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java, > > line 158 > > > > > > Are we guaranteed that the executor config exists here? The

Re: Review Request 50480: Multiple executor support in Scheduler

2016-07-28 Thread Renan DelValle
> On July 27, 2016, 1:47 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java, > > lines 205-208 > > > > > > I'd drop this in favor of EMPTY overhead

Re: Review Request 50480: Multiple executor support in Scheduler

2016-07-28 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50480/ --- (Updated July 28, 2016, 3:35 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
> On July 28, 2016, 8:44 p.m., David McLaughlin wrote: > > For me ROLLED_BACK has a clear meaning - a job that was rolled back due to > > a failed health check in the update process. Overloading like this is going > > to lead to ambiguity and I wouldn't be comfortable exposing this > >

Re: Review Request 50480: Multiple executor support in Scheduler

2016-07-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50480/#review144025 --- Ship it! Master (dde2c92) is green with this patch.

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144039 --- Ship it! Master (dde2c92) is green with this patch.

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144001 --- For me ROLLED_BACK has a clear meaning - a job that was rolled

Review Request 50584: Upgrade to Mesos 1.0.0

2016-07-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50584/ --- Review request for Aurora, Maxim Khutornenko and Steve Niemitz. Repository:

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144000 --- David makes a good comment. Maxim/Bill: What do you guys think

Re: Review Request 50584: Upgrade to Mesos 1.0.0

2016-07-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50584/#review144032 --- Ship it! Master (dde2c92) is green with this patch.

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review143981 --- Ship it! Master (dde2c92) is green with this patch.

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated July 28, 2016, 7:06 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
> On July 21, 2016, 9:12 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, > > lines 129-131 > > > > > > +1 > > > > I'm fine with having this "undo"

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
> On July 25, 2016, 7:57 p.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift, lines 95-99 > > > > > > The idea of update locks is entirely obsolete now that we don't have > >