Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Stephan Erb
> On Aug. 3, 2016, 3:58 a.m., Joshua Cohen wrote: > > So, on further reflection, it doesn't necessarily make sense for the > > response type to be dictated by the `Content-Type` of the request. We > > should probably use the `Accept` header instead? I don't necessarily know > > if the use case

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/ --- (Updated Aug. 3, 2016, 3:34 p.m.) Review request for Aurora, Jie Yu, Maxim Khut

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review144620 --- Ship it! Master (b912e17) is green with this patch. ./build-s

Re: Review Request 50480: Multiple executor support in Scheduler

2016-08-03 Thread Renan DelValle
> On Aug. 2, 2016, 7:36 p.m., Joshua Cohen wrote: > > I was about to push this change, but in the process of running e2e tests > > locally after applying your patch, it occurs to me that perhaps this is > > something we should have e2e coverage for. > > > > Do you think it would be feasible to

Re: Review Request 50480: Multiple executor support in Scheduler

2016-08-03 Thread Joshua Cohen
> On Aug. 3, 2016, 2:36 a.m., Joshua Cohen wrote: > > I was about to push this change, but in the process of running e2e tests > > locally after applying your patch, it occurs to me that perhaps this is > > something we should have e2e coverage for. > > > > Do you think it would be feasible to

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Zameer Manji
> On Aug. 2, 2016, 6:58 p.m., Joshua Cohen wrote: > > So, on further reflection, it doesn't necessarily make sense for the > > response type to be dictated by the `Content-Type` of the request. We > > should probably use the `Accept` header instead? I don't necessarily know > > if the use case

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144653 --- Ship it! Ship It! - Dmitriy Shirchenko On Aug. 3, 2016, 12:1

Re: Review Request 50480: Multiple executor support in Scheduler

2016-08-03 Thread Renan DelValle
> On Aug. 2, 2016, 7:36 p.m., Joshua Cohen wrote: > > I was about to push this change, but in the process of running e2e tests > > locally after applying your patch, it occurs to me that perhaps this is > > something we should have e2e coverage for. > > > > Do you think it would be feasible to

Re: Review Request 50480: Multiple executor support in Scheduler

2016-08-03 Thread Renan DelValle
> On Aug. 2, 2016, 7:36 p.m., Joshua Cohen wrote: > > I was about to push this change, but in the process of running e2e tests > > locally after applying your patch, it occurs to me that perhaps this is > > something we should have e2e coverage for. > > > > Do you think it would be feasible to

Re: Review Request 50480: Multiple executor support in Scheduler

2016-08-03 Thread Joshua Cohen
> On Aug. 3, 2016, 2:36 a.m., Joshua Cohen wrote: > > I was about to push this change, but in the process of running e2e tests > > locally after applying your patch, it occurs to me that perhaps this is > > something we should have e2e coverage for. > > > > Do you think it would be feasible to

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144666 --- Ship it! Ship It! - Stephan Erb On Aug. 3, 2016, 2:10 a.m.,

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated Aug. 3, 2016, 8:47 p.m.) Review request for Aurora, Joshua Cohen, Maxi

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144669 --- src/main/java/org/apache/aurora/scheduler/updater/JobUpdateContro

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144674 --- Ship it! Master (a071af3) is green with this patch. ./build-s

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Zameer Manji
> On Aug. 2, 2016, 6:58 p.m., Joshua Cohen wrote: > > So, on further reflection, it doesn't necessarily make sense for the > > response type to be dictated by the `Content-Type` of the request. We > > should probably use the `Accept` header instead? I don't necessarily know > > if the use case

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/ --- (Updated Aug. 3, 2016, 2:36 p.m.) Review request for Aurora, Joshua Cohen, Maxi

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated Aug. 3, 2016, 9:51 p.m.) Review request for Aurora, Joshua Cohen, Maxi

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144678 --- Ship it! Thanks for following up! src/main/java/org/apache/au

Re: Review Request 50480: Multiple executor support in Scheduler

2016-08-03 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50480/ --- (Updated Aug. 3, 2016, 3:01 p.m.) Review request for Aurora, Joshua Cohen and M

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ --- (Updated Aug. 3, 2016, 10:16 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144685 --- Ship it! Ship It! - Joshua Cohen On Aug. 3, 2016, 9:36 p.m.,

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144688 --- Ship it! Master (a071af3) is green with this patch. ./build-s

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144689 --- Ship it! Master (a071af3) is green with this patch. ./build-s

Re: Review Request 50480: Multiple executor support in Scheduler

2016-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50480/#review144693 --- Master (a071af3) is red with this patch. ./build-support/jenkins