Re: Review Request 51664: Document the Mesos containerizer

2016-09-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51664/ --- (Updated Sept. 9, 2016, 10:05 a.m.) Review request for Aurora and Joshua Cohen.

Review Request 51758: Document how to generate a changelog

2016-09-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51758/ --- Review request for Aurora, Joshua Cohen and Jake Farrell. Repository: aurora

Re: Review Request 51758: Document how to generate a changelog

2016-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51758/#review148334 --- Ship it! Master (c7f710a) is green with this patch. ./build-s

Re: Review Request 51758: Document how to generate a changelog

2016-09-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51758/#review148343 --- Ship it! Ship It! - Joshua Cohen On Sept. 9, 2016, 1:40 p.m.

Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

2016-09-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Reposit

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

2016-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/#review148349 --- Ship it! Master (c7f710a) is green with this patch. ./build-s

Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

2016-09-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Reposit

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 9, 2016, 6:32 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

2016-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review148356 --- Ship it! Master (c7f710a) is green with this patch. ./build-s

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 9, 2016, 6:43 p.m.) Review request for Aurora, Joshua Cohen, Max

Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Reposit

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148359 --- Ship it! Master (c7f710a) is green with this patch. ./build-s

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Maxim Khutornenko
> On Sept. 9, 2016, 12:26 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java, > > line 125 > > > > > > This smells to me and seems awkward. I guess this stemms

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review148362 --- Ship it! Master (c7f710a) is green with this patch. ./build-s

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148374 --- Ship it! LGTM src/test/java/org/apache/aurora/scheduler/recon