Re: Review Request 51980: Refactor of Webhook and no longer posting entire task state via webhook on scheduler restart

2016-09-20 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51980/#review149678 --- Ship it! Ship It! - Stephan Erb On Sept. 19, 2016, 8:28

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-20 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149681 ---

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/#review149690 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 20, 2016,

Re: Review Request 52074: switching from launchTask to acceptOffers

2016-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149698 --- Ship it! Master (4745c8c) is green with this patch.

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Joshua Cohen
> On Sept. 20, 2016, 5:53 p.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/admin/admin_util.py, line 272 > > > > > > docstring, please! Added. > On Sept. 20, 2016, 5:53 p.m., Dmitriy Shirchenko

Re: Review Request 51980: Refactor of Webhook and no longer posting entire task state via webhook on scheduler restart

2016-09-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51980/#review149674 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 19, 2016,

Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository:

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/#review149693 --- Master (4745c8c) is red with this patch.

Re: Review Request 52074: switching from launchTask to acceptOffers

2016-09-20 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- (Updated Sept. 20, 2016, 6:08 p.m.) Review request for Aurora, Maxim

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/ --- (Updated Sept. 20, 2016, 6:41 p.m.) Review request for Aurora, Maxim

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149744 --- Ship it! Master (8432894) is green with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-20 Thread Maxim Khutornenko
> On Sept. 16, 2016, 9:08 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java, line > > 197 > > > > > > Side show: Isn't that `if` unnecessary here and we can adjust

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-20 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149747 --- Ship it! Ship It! - Stephan Erb On Sept. 21, 2016, 12:02

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-20 Thread Maxim Khutornenko
> On Sept. 20, 2016, 6:49 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java, > > lines 93-96 > > > > > > Regarding your notes in the RB description: I don't see

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- (Updated Sept. 20, 2016, 10:02 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/#review149689 --- src/main/python/apache/aurora/admin/admin_util.py (line 272)

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/#review149696 --- Ship it! Don't forget to fill out the `Bugs` portion of the

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/ --- (Updated Sept. 20, 2016, 6:57 p.m.) Review request for Aurora, Maxim

Re: Review Request 52074: switching from launchTask to acceptOffers

2016-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149712 --- Ship it! Master (4745c8c) is green with this patch.

Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-20 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.

Re: Review Request 52093: Clean up some license issues.

2016-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52093/#review149723 --- Ship it! Master (f1eb1eb) is green with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-20 Thread Stephan Erb
> On Sept. 16, 2016, 11:08 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java, line > > 197 > > > > > > Side show: Isn't that `if` unnecessary here and we can adjust

Re: Review Request 52074: switching from launchTask to acceptOffers

2016-09-20 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/ --- (Updated Sept. 20, 2016, 7:14 p.m.) Review request for Aurora, Maxim

Re: Review Request 52074: switching from launchTask to acceptOffers

2016-09-20 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149714 ---

Review Request 52093: Clean up some license issues.

2016-09-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52093/ --- Review request for Aurora and Jake Farrell. Repository: aurora Description

Re: Review Request 52074: switching from launchTask to acceptOffers

2016-09-20 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149715 --- Ship it! Ship It! - Mehrdad Nurolahzade On Sept. 20, 2016,

Re: Review Request 52093: Clean up some license issues.

2016-09-20 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52093/#review149718 --- Ship it! Ship It! - Jake Farrell On Sept. 20, 2016, 7:48

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review149719 --- Ship it! Master (a9f4e26) is green with this patch.

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/#review149707 --- Ship it! Ship It! - Dmitriy Shirchenko On Sept. 20, 2016,

Re: Review Request 52074: switching from launchTask to acceptOffers

2016-09-20 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149709 --- Fix it, then Ship it! LGTM. I'm surprised at how small of a

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

2016-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/#review149711 --- Ship it! Master (4745c8c) is green with this patch.