Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-23 Thread Kai Huang
> On Sept. 23, 2016, 10:18 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, line 120 > > > > > > This check is brittle to determine if health checking is enabled. > > Please

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review150246 --- I like the additional testing done.

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150161 --- Ship it! Master (4ead189) is green with this patch.

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review150200 --- src/main/python/apache/aurora/executor/aurora_executor.py (line

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review150226 --- Ship it! Master (4ead189) is green with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review150225 --- lgtm overall. Only potential blocker is the last comment (which

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-23 Thread Kai Huang
> On Sept. 23, 2016, 4:53 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, line 81 > > > > > > I don't think we should expose this simply for the sake of testing, > > besides

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-23 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/ --- (Updated Sept. 23, 2016, 6:58 p.m.) Review request for Aurora, Joshua Cohen,