Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151456 --- This patch does not apply cleanly against master (251ef5a), do

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/ --- (Updated Oct. 4, 2016, 9:55 p.m.) Review request for Aurora, George Sirois,

Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/ --- (Updated Oct. 4, 2016, 5:03 p.m.) Review request for Aurora. Changes ---

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151376 --- Thanks for the patch and sorry for the massiv delay. Would be

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151372 --- On further reflection, can you also add a section documenting of

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151373 --- Changes LGTM. Can we add documentation as well? We need to

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 4, 2016, 7:17 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/api/updater_util.py, line 39 > > > > > > "Watch seconds should not be negative." sure. Will do. - Kai

Review Request 52521: Replace wfarner with zmanji as default reviewer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52521/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description

Re: Review Request 52521: Replace wfarner with zmanji as default reviewer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52521/#review151361 --- Ship it! Ship It! - Joshua Cohen On Oct. 4, 2016, 6:10

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

> On Oct. 4, 2016, 9:23 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 99 > > > > > > Should we consider using the `AURORA_LABEL_PREFIX` prefix here as

Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/#review151418 --- Ship it! Master (251ef5a) is green with this patch.

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52527/#review151405 --- Ship it! Master (ebdaa6b) is green with this patch.

Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/ --- Review request for Aurora. Repository: aurora Description --- Support

Review Request 52527: Expose task tier as a label on TaskInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52527/ --- Review request for Aurora, Stephan Erb and Zameer Manji. Repository: aurora

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

> On Oct. 4, 2016, 2:10 p.m., Stephan Erb wrote: > > This change will be backwards incompatible. For example, it will break the > > Prometheus Aurora exporter: > > https://github.com/tommyulfsparre/aurora_exporter/blob/master/main.go#L101 > > > > So the question: Do we consider this endpoint

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52527/ --- (Updated Oct. 4, 2016, 9:32 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review151391 --- This change will be backwards incompatible. For example, it will

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52527/#review151402 --- Ship it! Ship It! - Zameer Manji On Oct. 4, 2016, 2:08

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52527/#review151404 --- Fix it, then Ship it! LGTM RELEASE-NOTES.md (line 8)

Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/#review151416 --- Fix it, then Ship it! Looks good to me, thanks! I don't have

Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

> On Oct. 4, 2016, 3:25 p.m., Dmitriy Shirchenko wrote: > > build-support/python/make-mesos-native-egg, line 78 > > > > > > Any reason why you aren't using debian/jessie [1] vagrant image name as > > a label and

Review Request 52508: Order job update events and instance events by ID rather than timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52508/ --- Review request for Aurora. Repository: aurora Description --- Order job

Re: Review Request 52508: Order job update events and instance events by ID rather than timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52508/#review151311 --- Master (ed72b1b) is green with this patch.

Re: Review Request 52508: Order job update events and instance events by ID rather than timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52508/ --- (Updated Oct. 4, 2016, 8:51 a.m.) Review request for Aurora, Joshua Cohen and

Review Request 52506: Order job update events and instance events by ID rather than timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52506/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-655

Re: Review Request 52508: Order job update events and instance events by ID rather than timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52508/#review151332 --- Ship it! Ship It! - Joshua Cohen On Oct. 4, 2016, 8:51

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 4, 2016, 6:36 a.m., Kai Huang wrote: > > I noticed that AuroraBot says the test is green but some coverage are > > missing... > > > > When I test the code locally, the code passes pants tests and style check > > in: > > ./build-support/jenkins/build.sh > > > > it also passes

Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

> On Oct. 5, 2016, 12:31 a.m., Stephan Erb wrote: > > build-support/python/make-mesos-native-egg, line 78 > > > > > > How about using the 'official' one here `debian/jessie64`? Adding a comment and bumping the

Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/#review151432 --- Ship it! Master (251ef5a) is green with this patch.

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151449 --- @ReviewBot retry - Santhosh Kumar Shanmugham On Oct. 3, 2016,

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review151341 --- The general approach looks reasonable to me. Please address the

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151303 --- I noticed that AuroraBot says the test is green but some coverage

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 4, 2016, 6:36 a.m., Kai Huang wrote: > > I noticed that AuroraBot says the test is green but some coverage are > > missing... > > > > When I test the code locally, the code passes pants tests and style check > > in: > > ./build-support/jenkins/build.sh > > > > it also passes