Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review153144 --- Ship it! Ship It! - Zameer Manji On Oct. 18, 2016, 11:22

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review153139 --- Ship it! Master (ad77de1) is green with this patch.

Re: Review Request 52957: Handle the case where content type header is null.

2016-10-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52957/#review153045 --- Ship it! Thanks for picking this up! - Stephan Erb On Oct.

Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Justin Pinkul
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53003/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1798

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Justin Pinkul
> On Oct. 18, 2016, 11:59 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 308-313 > > > > > > Is this always necessary, or only necessary when filesystem isolation > >

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53003/#review153190 --- Ship it! Ship It! - Zameer Manji On Oct. 18, 2016, 3:13

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53003/#review153196 --- Master (485504a) is red with this patch.

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53003/#review153217 --- src/main/python/apache/aurora/executor/common/sandbox.py (lines

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Joshua Cohen
> On Oct. 18, 2016, 11:59 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 308-313 > > > > > > Is this always necessary, or only necessary when filesystem isolation > >

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53003/#review153219 --- Ship it! Master (485504a) is green with this patch.

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Justin Pinkul
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53003/ --- (Updated Oct. 18, 2016, 11:41 p.m.) Review request for Aurora, Joshua Cohen