Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53508/ --- (Updated Nov. 4, 2016, 5:53 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53508/#review155021 --- Master (5410c22) is red with this patch.

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53508/#review155027 --- @ReviewBot retry - Zameer Manji On Nov. 4, 2016, 4:54 p.m.,

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53508/ --- (Updated Nov. 4, 2016, 4:54 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53508/#review155032 --- Master (5410c22) is red with this patch.

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53508/ --- (Updated Nov. 4, 2016, 5:53 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53508/#review155039 --- Ship it! Master (5410c22) is green with this patch.

Re: Review Request 53418: Send SIGTERM to daemonized processes on shutdown.

2016-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53418/#review154876 --- Master (171a8f7) is red with this patch.

Re: Review Request 53452: Log TaskInfo and Assigned Task on task startup.

2016-11-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53452/#review154905 --- Ship it! I am not sure we really need to log both TaskConfig

Re: Review Request 53452: Log TaskInfo and Assigned Task on task startup.

2016-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53452/#review154906 --- Master (35435cb) is green with this patch.

Re: Review Request 53452: Log TaskInfo and Assigned Task on task startup.

2016-11-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53452/#review154900 --- @ReviewBot retry - Stephan Erb On Nov. 4, 2016, 1:52 a.m.,

Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-11-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53114/#review154902 --- src/main/python/apache/aurora/client/cli/jobs.py (lines 287 -

Re: Review Request 52884: Document how to create a custom CLI build

2016-11-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review154890 --- The patch looks good and got signed off by a sufficient number of

Re: Review Request 53418: Send SIGTERM to daemonized processes on shutdown.

2016-11-04 Thread Stephan Erb
> On Nov. 4, 2016, 5:03 p.m., Stephan Erb wrote: > > LGTM in general. I may not be around for the rest of the day and the > > weekend, so I mark thas 'Ship it, then fix it'. Ahh, "Fix it, then Ship it!" :-) - Stephan --- This is an