Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review187962 --- When I implemented this originally I wanted it to be a separate

Re: Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/ --- (Updated Oct. 13, 2017, 4:36 p.m.) Review request for Aurora, David

Re: Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-13 Thread Stephan Erb
> On Oct. 9, 2017, 4:49 a.m., John Sirois wrote: > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > > Line 42 (original), 42 (patched) > > > > > > Is this worth an entry in

Re: Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187964 --- Ship it! Master (2aee90d) is green with this patch.

Re: Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187965 --- Ship it! Ship It! - John Sirois On Oct. 13, 2017, 8:36

Re: Review Request 62956: Immediately reject offers lacking necessary resources

2017-10-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review187939 ---

Re: Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-13 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187985 --- Ship it! Ship It! - Renan DelValle On Oct. 13, 2017, 7:36