Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/ --- (Updated Nov. 14, 2017, 10:41 p.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191013 --- Ship it! Master (4fecf1f) is green with this patch.

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-14 Thread David McLaughlin
> On Nov. 9, 2017, 5:23 p.m., Bill Farner wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 526 (patched) > > > > > > It seems logical that this accounting would live alongside > >

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-14 Thread David McLaughlin
> On Nov. 9, 2017, 1:10 a.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java > > Lines 57 (patched) > > > > > > I don't think you need to `synchronize` here since it is a

Re: Review Request 63750: pants for high-sierra

2017-11-14 Thread Stephan Erb
> On Nov. 13, 2017, 5:05 p.m., Bill Farner wrote: > > Stephan - FYI, i reproduce the build error: > > ``` > > Exception message: Could not satisfy all requirements for > > mesos.executor==1.4.0: > > mesos.executor==1.4.0 > > ``` > > Stephan Erb wrote: > Interesting. Does it go away

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191025 --- I think this change is sufficiently complex that it warrants an

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/ --- (Updated Nov. 15, 2017, 12:05 a.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191021 --- Ship it! Master (4fecf1f) is green with this patch.

Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63763/#review191024 --- Ship it! Ship It! - Bill Farner On Nov. 13, 2017, 3:58

Re: Review Request 63750: pants for high-sierra

2017-11-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/#review191018 --- Master (4fecf1f) is red with this patch.