Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 22, 2018, 2:02 p.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199763 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66199: Remove unused LOST_LOCK_MESSAGE variable in JobUpdateControllerImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66199/#review199771 --- Ship it! Ship It! - Stephan Erb On March 21, 2018, 10:38

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/#review199774 --- Ship it! Ship It! - Stephan Erb On March 21, 2018, 9:23

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199791 --- src/main/python/apache/thermos/monitoring/disk.py Lines 132

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 22, 2018, 9:52 p.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199741 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 23, 2018, 12:59 a.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199830 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199822 --- src/test/python/apache/thermos/monitoring/BUILD Lines 21

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199814 --- Fix it, then Ship it! Implementation LGTM. Some more comments

Re: Review Request 66103: Introduce mesos disk collector

> On March 22, 2018, 10:31 p.m., Stephan Erb wrote: > > src/test/python/apache/thermos/monitoring/BUILD > > Lines 21 (patched) > > > > > > Requests has a few dependencies. I believe you need to list those here > >

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199838 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 22,

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199812 --- Querying information from Mesos rather than re-doing it in

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199815 --- Master (f32086d) is red with this patch.