Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Jordan Ly
> On July 9, 2018, 9:04 p.m., Santhosh Kumar Shanmugham wrote: > > src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java > > Lines 180 (patched) > > > > > > Drop `_` here and everywhere.

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67696/#review206026 --- Ship it! Master (a6d9288) is green with this patch.

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67696/ --- (Updated July 12, 2018, 9:10 p.m.) Review request for Aurora, David

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Santhosh Kumar Shanmugham
> On July 9, 2018, 2:04 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java > > Lines 140 (patched) > > > > > > Repeating my comment from internal

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67696/#review206024 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On July 12,

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Daniel Knightly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67696/#review206028 ---

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Daniel Knightly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67696/#review206034 --- Ship it! Ship It! - Daniel Knightly On July 12, 2018, 9:10