Re: Review Request 32641: Dropping incubator from Aurora.

2015-03-30 Thread Jake Farrell
whole disclaimer file should be removed - Jake Farrell On March 30, 2015, 9:08 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32641

Re: Review Request 32641: Dropping incubator from Aurora.

2015-03-30 Thread Jake Farrell
/r/32641/#comment126845 '-incubating' also appears in the release and release-candidate scripts and needs to be removed as part of this - Jake Farrell On March 31, 2015, 1:34 a.m., Maxim Khutornenko wrote

Review Request 33774: Aurora-1106: Release candidate script does not generate correct branch link

2015-05-01 Thread Jake Farrell
14dbeddac663733b23383643dad91db0abe8b9f7 Diff: https://reviews.apache.org/r/33774/diff/ Testing --- Thanks, Jake Farrell

Review Request 33773: Aurora-1302: Allow rc script to set an explicit version

2015-05-01 Thread Jake Farrell
8433b65] Updating .auroraversion to 0.8.0-rc0. 1 file changed, 1 insertion(+), 1 deletion(-) Building the source distribution Signing the distribution You need a passphrase to unlock the secret key for user: Jake Farrell jfarr...@apache.org 2048-bit DSA key, ID 66B778F9, created 2011-04-13 gpg: gpg

Re: Review Request 33773: Aurora-1302: Allow rc script to set an explicit version

2015-05-03 Thread Jake Farrell
key for user: Jake Farrell jfarr...@apache.org 2048-bit DSA key, ID 66B778F9, created 2011-04-13 gpg: gpg-agent is not available in this session Creating checksums Done creating the release candidate. The following draft email has been created to send to the d...@aurora.apache.org mailing

Review Request 33950: AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references

2015-05-07 Thread Jake Farrell
--- Thanks, Jake Farrell

Review Request 33969: Fix broken style test cases causing PEP302

2015-05-07 Thread Jake Farrell
src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py afd59a18fb6de9347f3ac44d78e5110ce1252fee Diff: https://reviews.apache.org/r/33969/diff/ Testing --- all tests including check style pass with this patch now Thanks, Jake Farrell

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-07 Thread Jake Farrell
On May 4, 2015, 7:31 p.m., Bill Farner wrote: We've had success with using vagrant to serve as test beds and build environments for things like this [1]. Docker might be a boon here, as we can use that in ASF's jenkins. Don't hesitate to punt on this for now, as it's not a

Review Request 33967: AURORA-1312: Fix missing license headers in new files added since 0.7.0

2015-05-07 Thread Jake Farrell
/Dockerfile d316b87dc0cd5b8ee0d66f6fd673ccdf19b58043 Diff: https://reviews.apache.org/r/33967/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 33967: AURORA-1312: Fix missing license headers in new files added since 0.7.0

2015-05-07 Thread Jake Farrell
13016cbd9defdaff53cfcf367a413fb6899425a7 src/test/resources/org/apache/thermos/root/checkpoints/README 2a57f57556396826e0b05de1018ad38bf24c9cc8 src/test/sh/org/apache/aurora/e2e/Dockerfile d316b87dc0cd5b8ee0d66f6fd673ccdf19b58043 Diff: https://reviews.apache.org/r/33967/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 33854: Fix and enhance RC verification script.

2015-05-07 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33854/#review82898 --- Ship it! Ship It! - Jake Farrell On May 7, 2015, 8:20 p.m

Re: Review Request 33950: Fix 0.8.0-RC0 issues raised due to changelog containing wontfix and duplicate ticket references

2015-05-07 Thread Jake Farrell
/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638 Diff: https://reviews.apache.org/r/33950/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 33854: Fix and enhance RC verification script.

2015-05-07 Thread Jake Farrell
://reviews.apache.org/r/33854/#comment133674 Not crazy about having multiple locations for gradle versions to be set, do we have to include gradle download here or could we just assume that gradle is all ready on the system as a build dependency - Jake Farrell On May 5, 2015, 10:14 p.m., Bill Farner

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-06-23 Thread Jake Farrell
this in for 0.9.0 - Jake Farrell On May 19, 2015, 4:19 p.m., Steve Salevan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-05 Thread Jake Farrell
├── build-support │   ├── jenkins │   └── release ├── docs └── packaging ├── deb ├── docker │   ├── centos │   └── ubuntu └── rpm ``` - Jake Farrell On Aug. 5, 2015, 1:21 a.m., Bill Farner wrote

Re: Review Request 37666: Import of Twitter Commons.

2015-08-24 Thread Jake Farrell
up patch to change this to the propper license headers and moved to the apache namespace as discussed on the dev@aurora list - Jake Farrell On Aug. 25, 2015, 12:03 a.m., Zameer Manji wrote: --- This is an automatically generated e

Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-14 Thread Jake Farrell
es all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Jake Farrell

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-15 Thread Jake Farrell
aurora/e2e/test_end_to_end.sh Thanks, Jake Farrell

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-15 Thread Jake Farrell
lue. Passes all test cases and e2e. - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review98979 ------- On

Re: Review Request 37851: Use "Mesos Agent" instead of "Mesos Slave" in docs.

2015-09-28 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37851/#review100841 --- Ship it! Ship It! - Jake Farrell On Aug. 27, 2015, 6:52 p.m

Re: Review Request 36874: Fix typo in the scheduler deployment documentation

2015-09-28 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36874/#review100842 --- Ship it! Ship It! - Jake Farrell On July 28, 2015, 3:01 a.m

Review Request 38975: AURORA-1512: Aurora rpm missing std output switch

2015-10-02 Thread Jake Farrell
://reviews.apache.org/r/38975/diff/ Testing --- Thanks, Jake Farrell

Review Request 40877: Update rpm startup scripts to match deb patterns in use

2015-12-02 Thread Jake Farrell
/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 41785: Remove scheduler log scaffolding

2016-01-04 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review112751 --- Ship it! Ship It! - Jake Farrell On Jan. 4, 2016, 5:04 a.m

Re: Review Request 42919: Fixup RC VOTE email instructions.

2016-01-28 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42919/#review116811 --- Ship it! Ship It! - Jake Farrell On Jan. 28, 2016, 8:22 p.m

Re: Review Request 44806: Rename NEWS to RELEASE-NOTES.md

2016-03-14 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44806/#review123554 --- Ship it! Ship It! - Jake Farrell On March 14, 2016, 8:44

Re: Review Request 46070: Fix stale NEWS RC email link.

2016-04-11 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46070/#review128334 --- Ship it! Ship It! - Jake Farrell On April 12, 2016, 4:55

Review Request 46098: AURORA-1584: Aurora 0.13.0 release candidate missing CHANGELOG

2016-04-12 Thread Jake Farrell
--- Thanks, Jake Farrell

Re: Review Request 44347: Install thrift package from the offical debs.

2016-03-03 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44347/#review121917 --- Ship it! Ship It! - Jake Farrell On March 3, 2016, 6:56 p.m

Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-02 Thread Jake Farrell
> On Aug. 2, 2016, 1:57 a.m., David McLaughlin wrote: > > Approach seems fine to me, with the exception that we need to maintain > > backwards compatibility by assuming the existing behavior when no > > content-type is specified in the request. +1, easy enough to use the mime type and default

Re: Review Request 52046: Adding gpg key for jco...@apache.org

2016-09-19 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52046/#review149520 --- Ship it! Ship It! - Jake Farrell On Sept. 19, 2016, 6:28

Re: Review Request 52049: Clarifying documentation for new contributors by adding a step for them to ask for their JIRA id to get whitelisted

2016-09-19 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52049/#review149528 --- Ship it! Ship It! - Jake Farrell On Sept. 19, 2016, 6:42

Re: Review Request 52093: Clean up some license issues.

2016-09-20 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52093/#review149718 --- Ship it! Ship It! - Jake Farrell On Sept. 20, 2016, 7:48