Re: Review Request 32559: Add Kerberos support to the scheduler

2015-03-27 Thread Joshua Cohen
On March 27, 2015, 6:09 p.m., Joshua Cohen wrote: src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java, line 42 https://reviews.apache.org/r/32559/diff/2/?file=907398#file907398line42 It feels like most of this stuff can be tested

Re: Review Request 32559: Add Kerberos support to the scheduler

2015-03-27 Thread Joshua Cohen
subsequent end to end test runs will fail? Or alternately just set up a separate service for scheduler w/ kerberos and stop the normal scheduler, start the kerb one, run tests, then stop/start in reverse? - Joshua Cohen On March 27, 2015, 1:23 a.m., Kevin Sweeney wrote

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-27 Thread Joshua Cohen
On March 27, 2015, 11:44 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetters.java, lines 25-26 https://reviews.apache.org/r/32329/diff/4/?file=908521#file908521line25 I don't think I've ever run into the scenario where a method had

Re: Review Request 32554: Enable gradle daemon in Vagrant.

2015-03-26 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32554/#review77965 --- Ship it! Ship It! - Joshua Cohen On March 26, 2015, 10:45 p.m

Re: Review Request 33411: Add typed Shiro permissions SPI.

2015-04-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81174 --- Ship it! Ship It! - Joshua Cohen On April 21, 2015, 11 p.m

Re: Review Request 33317: Upgrade to pystachio 0.8.0

2015-04-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33317/#review80803 --- Ship it! Ship It! - Joshua Cohen On April 20, 2015, 7:17 p.m

Re: Review Request 33705: Don't retry API requests that fail with auth errors.

2015-04-30 Thread Joshua Cohen
On April 30, 2015, 7:15 p.m., Joshua Cohen wrote: src/main/python/apache/aurora/common/transport.py, line 64 https://reviews.apache.org/r/33705/diff/1/?file=945910#file945910line64 Is this meant to indicate that it should be a function that returns a Session? Is this a standard

Re: Review Request 33705: Don't retry API requests that fail with auth errors.

2015-04-30 Thread Joshua Cohen
Is this meant to indicate that it should be a function that returns a Session? Is this a standard that's documented somewhere? - Joshua Cohen On April 30, 2015, 12:12 a.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 33728: Fix query for active job updates when serving /updates.

2015-04-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33728/#review82181 --- Ship it! Ship It! - Joshua Cohen On April 30, 2015, 6:59 p.m

Re: Review Request 33537: Document Aurora security features.

2015-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81851 --- Ship it! Ship It! - Joshua Cohen On April 27, 2015, 11:24 p.m

Re: Review Request 33962: Remove often-redundant Error executing command prefix from client output.

2015-05-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33962/#review82947 --- Ship it! Ship It! - Joshua Cohen On May 8, 2015, 12:16 a.m

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-07 Thread Joshua Cohen
I'm totally unclear on our guidelines for javadoc. Usually on interface methods we'd require javadoc, does that not hold here for some reason since it's a MyBatis mapper? - Joshua Cohen On May 5, 2015, 6:21 p.m., Bill Farner wrote

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33991/#review83038 --- Ship it! Ship It! - Joshua Cohen On May 8, 2015, 6:10 p.m

Re: Review Request 33999: Add missing binding to ThriftApiBenchmarks.

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33999/#review83102 --- Ship it! Ship It! - Joshua Cohen On May 8, 2015, 8:45 p.m

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83118 --- Ship it! Ship It! - Joshua Cohen On May 9, 2015, 12:11 a.m

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joshua Cohen
://reviews.apache.org/r/33997/#comment133934 do we need to explicitly set this to /tmp? Won't it use TMPDIR by default? - Joshua Cohen On May 8, 2015, 8:20 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-11 Thread Joshua Cohen
On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, lines 102-106 https://reviews.apache.org/r/33612/diff/2/?file=950462#file950462line102 It'd be nice if this was extracted out to a higher level so

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-12 Thread Joshua Cohen
On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, lines 102-106 https://reviews.apache.org/r/33612/diff/2/?file=950462#file950462line102 It'd be nice if this was extracted out to a higher level so

Re: Review Request 34307: Upgrade pants to 0.0.32

2015-05-18 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34307/#review84212 --- Ship it! Ship It! - Joshua Cohen On May 16, 2015, 1:20 a.m

Re: Review Request 34372: Place api_util.py inside a `pants_library` target.

2015-05-18 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34372/#review84219 --- Ship it! Ship It! - Joshua Cohen On May 18, 2015, 9:05 p.m

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Joshua Cohen
: # block begins here - Joshua Cohen On April 11, 2015, 9:52 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889

Re: Review Request 33026: Revert Make health check configurable

2015-04-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33026/#review79541 --- Ship it! Ship It! - Joshua Cohen On April 9, 2015, 6:03 p.m

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-03 Thread Joshua Cohen
/JettyServerModule.java https://reviews.apache.org/r/32806/#comment127835 +newline before - Joshua Cohen On April 3, 2015, 3:06 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86879 --- @ReviewBot retry - Joshua Cohen On May 21, 2015, 11:28 p.m

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86878 --- Ship it! Presumably you'll need to rebase. - Joshua Cohen

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Joshua Cohen
/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java https://reviews.apache.org/r/34566/#comment138690 Same here and below. - Joshua Cohen On June 3, 2015, 10:08 p.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Joshua Cohen
On June 4, 2015, 4:36 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java, lines 78-80 https://reviews.apache.org/r/34566/diff/2/?file=977711#file977711line78 Why don't need this anymore? Er, ignore this, I

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review86711 --- Ship it! Ship It! - Joshua Cohen On June 4, 2015, 7:31 p.m

Re: Review Request 35839: Add exact times to update UI.

2015-06-24 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35839/#review89236 --- Ship it! Ship It! - Joshua Cohen On June 24, 2015, 7:05 p.m

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Joshua Cohen
/UnsecureAuthModule.java (line 34) https://reviews.apache.org/r/35535/#comment140545 Should this move to UnsecureSessionContext? - Joshua Cohen On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Joshua Cohen
/test_thermos_observer_entry_point.py (lines 27 - 30) https://reviews.apache.org/r/35527/#comment140542 There's a way to set this up so that only these expected properties are accessed, right? Is it by doing `Mock(spec_set=['root','mesos_root',...])`? In any event, we should probably do that? - Joshua Cohen

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/#review88154 --- Ship it! Ship It! - Joshua Cohen On June 16, 2015, 10:18 p.m

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Joshua Cohen
https://reviews.apache.org/r/34440/#comment136454 Add @Positive here as well. - Joshua Cohen On May 22, 2015, 8:47 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Joshua Cohen
On May 22, 2015, 8:52 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186 https://reviews.apache.org/r/34440/diff/2-3/?file=964680#file964680line186 Add @Positive here as well. Maxim Khutornenko wrote: Well, this can

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Joshua Cohen
and say database admin TCP server - Joshua Cohen On May 21, 2015, 9:15 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566

Re: Review Request 34679: Correcting typo in developing-aurora-client.md for readability.

2015-05-26 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34679/#review85257 --- Ship it! Ship It! - Joshua Cohen On May 26, 2015, 9:05 p.m

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-12 Thread Joshua Cohen
-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-17 Thread Joshua Cohen
/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-18 Thread Joshua Cohen
-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
of this (just convert your email to dev@ to markdown? ;)). src/main/python/apache/thermos/bin/BUILD (line 36) https://reviews.apache.org/r/36972/#comment148126 Should this read from .auroraversion? - Joshua Cohen On July 31, 2015, 3:37 a.m., Kevin Sweeney wrote

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
On July 31, 2015, 10:57 p.m., Joshua Cohen wrote: I'm -1 to shipping without something under docs/ explaining this organizational structure. Bill Farner wrote: maybe a README.md under `src/main/python/apache` instead? Kevin Sweeney wrote: I've added a new file docs/build

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93829 --- Ship it! Ship It! - Joshua Cohen On July 31, 2015, 11:22 p.m

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
this organizational structure. - Joshua Cohen On July 31, 2015, 10:49 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972

Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
of the progress indicators in action. File Attachments Progress indicators in action https://reviews.apache.org/media/uploaded/files/2015/08/05/b4e2fab2-9a3e-4910-b02f-e31de2631e87__update-page.mov Thanks, Joshua Cohen

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
-e31de2631e87__update-page.mov Thanks, Joshua Cohen

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94293 --- On Aug. 5, 2015, 8:28 p.m., Joshua Cohen wrote

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
://reviews.apache.org/r/37137/#review94303 --- On Aug. 5, 2015, 8:28 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
think we should remove the -webkit prefix and just stick to the standard css3 names. Joshua Cohen wrote: -moz is not necessary. Firefox has supported prefix-less keyframes since version 16 (current stable is 39) which was released in 2012. Current Safari does not work without

Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-11 Thread Joshua Cohen
://reviews.apache.org/r/37365/diff/ Testing --- - ./gradlew jsHint - ./pants test src/test/python/apache/aurora/client:base - Verified update page url in client was correct in Vagrant. - See attached screenshot for an example of what the instance page looks like. Thanks, Joshua Cohen

Re: Review Request 37092: Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.

2015-08-04 Thread Joshua Cohen
8850e9382f4192873fe2d785e75a7d73403696d6 Diff: https://reviews.apache.org/r/37092/diff/ Testing --- Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler. Thanks, Joshua Cohen

Review Request 37092: Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.

2015-08-04 Thread Joshua Cohen
the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler. Thanks, Joshua Cohen

Re: Review Request 37092: Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.

2015-08-04 Thread Joshua Cohen
/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6 Diff: https://reviews.apache.org/r/37092/diff/ Testing --- Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler. Thanks, Joshua Cohen

Re: Review Request 37206: Fixing slave/task reservation check.

2015-08-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37206/#review94557 --- Ship it! Ship It! - Joshua Cohen On Aug. 7, 2015, 4:12 a.m

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-14 Thread Joshua Cohen
://reviews.apache.org/media/uploaded/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-14 Thread Joshua Cohen
--- On Aug. 14, 2015, 2:44 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-14 Thread Joshua Cohen
. Joshua Cohen wrote: This is pretty standard mechanism for inheritance in JS. We could remove the .call invocation, but then if something changed in the future that *did* bind to `this` in the parent it wouldn't work properly. I'd prefer to keep it as is. David McLaughlin wrote: So

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-14 Thread Joshua Cohen
/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-14 Thread Joshua Cohen
. Joshua Cohen wrote: This is pretty standard mechanism for inheritance in JS. We could remove the .call invocation, but then if something changed in the future that *did* bind to `this` in the parent it wouldn't work properly. I'd prefer to keep it as is. David McLaughlin wrote: So

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

2015-08-14 Thread Joshua Cohen
(line 156) https://reviews.apache.org/r/37366/#comment150369 nit: any reason this declaration was moved after it's usage? - Joshua Cohen On Aug. 13, 2015, 9:46 p.m., Maxim Khutornenko wrote: --- This is an automatically generated

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

2015-08-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/#review95434 --- Ship it! Ship It! - Joshua Cohen On Aug. 13, 2015, 9:46 p.m

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-14 Thread Joshua Cohen
. Joshua Cohen wrote: This is pretty standard mechanism for inheritance in JS. We could remove the .call invocation, but then if something changed in the future that *did* bind to `this` in the parent it wouldn't work properly. I'd prefer to keep it as is. David McLaughlin wrote: So

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-14 Thread Joshua Cohen
/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-12 Thread Joshua Cohen
/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-12 Thread Joshua Cohen
/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png Thanks, Joshua Cohen

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-12 Thread Joshua Cohen
., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 12, 2015, 4:40 p.m.) Review

Re: Review Request 36671: Enforce a minimum java version rather than failing to compile when language features are not available in the current JDK.

2015-07-22 Thread Joshua Cohen
'aurora'. Build requires at least Java 1.8; but 1.7 was found. Build succeeds w/ JDK8. Thanks, Joshua Cohen

Re: Review Request 36703: Remove unnecessary uses of Guava Joiner.

2015-07-22 Thread Joshua Cohen
. To reply, visit: https://reviews.apache.org/r/36703/ --- (Updated July 22, 2015, 7:30 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Remove unnecessary use of Guava

Re: Review Request 36818: Wrong label on table heading for in progress updates

2015-07-26 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36818/#review93064 --- Ship it! Ship It! - Joshua Cohen On July 27, 2015, 12:24 a.m

Review Request 36671: Enforce a minimum java version rather than failing to compile when language features are not available in the current JDK.

2015-07-21 Thread Joshua Cohen
. Thanks, Joshua Cohen

Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Joshua Cohen
-25_at_9.59.50_AM.png Thanks, Joshua Cohen

Re: Review Request 39366: Adding job update diff details into "aurora job diff" command.

2015-10-21 Thread Joshua Cohen
> On Oct. 20, 2015, 4:49 p.m., Joshua Cohen wrote: > > Not a blocker, but do you think the arrows in the output are necessary? > > They feel like extra noise to me. Maybe replace them with tabs instead? > > Maxim Khutornenko wrote: > Certainly not married to th

Re: Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40201/#review106421 --- Ship it! Ship It! - Joshua Cohen On Nov. 13, 2015, 3:32 p.m

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread Joshua Cohen
's git shows the [same thing](https://git-wip-us.apache.org/repos/asf?p=aurora.git;a=blob;f=pants.ini;h=22f6c59dd93c1a4a2ca78c216e1fd3f3f6c8b752;hb=HEAD). - Joshua Cohen On Nov. 11, 2015, 8:30 p.m., John Sirois

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/#review106422 --- Ship it! Ship It! - Joshua Cohen On Nov. 11, 2015, 8:30 p.m

Re: Review Request 40220: Modernize the pex venv script.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/#review106419 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2015, 8:35 a.m

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106448 --- Ship it! Ship It! - Joshua Cohen On Nov. 13, 2015, 4:34 p.m

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106678 --- Ship it! Ship It! - Joshua Cohen On Nov. 15, 2015, 11:36 p.m

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread Joshua Cohen
ws.apache.org/r/40310/#comment165418> Why kill this? It seems like the intention was to ensure that set quota is called with the correct types, but the assert above still passes if we were to do `assert_called_with(role, 24, 4001.0, 6001.0)`, thus the explicit type checks were necessary? - J

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106694 --- Ship it! Ship It! - Joshua Cohen On Nov. 16, 2015, 5:30 p.m

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106693 --- Ship it! Ship It! - Joshua Cohen On Nov. 16, 2015, 5:42 p.m

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Joshua Cohen
> On Oct. 30, 2015, 2:31 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 305-306 > > <https://reviews.apache.org/r/39797/diff/1/?file=1112716#file1112716line305> > > > > It seems like this friendly err

Re: Review Request 39366: Adding job update diff details into "aurora job diff" command.

2015-10-16 Thread Joshua Cohen
in the testing done section, would it be possible to collapse the output into instance ranges? So instead of [100, 101, 102, ... 119], we just get [100-119]? - Joshua Cohen On Oct. 16, 2015, 12:25 a.m., Maxim Khutornenko wrote

Review Request 39114: Add a note about updating the aurora-packagine repo when changing the gradle version.

2015-10-07 Thread Joshua Cohen
--- Add a note about updating the aurora-packagine repo when changing the gradle version. Diffs - buildSrc/gradle.properties 9e3f26fb466aecbed30d0d000d07c3873d71b117 Diff: https://reviews.apache.org/r/39114/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 39113: Use gradle 2.7 in builds.

2015-10-07 Thread Joshua Cohen
to update these as well whenever updating the gradle version (maybe point to this review as an example)? - Joshua Cohen On Oct. 8, 2015, 3:02 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 39113: Use gradle 2.7 in builds.

2015-10-07 Thread Joshua Cohen
> On Oct. 8, 2015, 3:56 a.m., Joshua Cohen wrote: > > Mind adding a note to build.gradle in the aurora repo to update these as > > well whenever updating the gradle version (maybe point to this review as an > > example)? > > Bill Farner wrote: > The source

Re: Review Request 39366: Adding job update diff details into "aurora job diff" command.

2015-10-20 Thread Joshua Cohen
equest` and again right after. I'd remove the log from `_job_update_request`? - Joshua Cohen On Oct. 19, 2015, 5:23 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39089: Better handling of enums and constructor-only classes in test coverage check.

2015-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39089/#review101777 --- Ship it! Ship It! - Joshua Cohen On Oct. 7, 2015, 3:31 p.m

Re: Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39095/#review101791 --- Ship it! Ship It! - Joshua Cohen On Oct. 7, 2015, 4:50 p.m

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

2015-10-08 Thread Joshua Cohen
15, 11:35 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39150/ > --- > > (Updated Oct. 8, 2015, 11:35 p.m.) >

Re: Review Request 36064: Perform leader redirect using HTTP status code 307

2015-07-08 Thread Joshua Cohen
and this got buried. Looks fine to me! - Joshua Cohen On July 5, 2015, 7:38 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36064

Review Request 37809: Use a copy of the table config to avoid contaminating pagination settings.

2015-08-26 Thread Joshua Cohen
active tasks were paginated but 2 completed tasks (for the same job) did not. Thanks, Joshua Cohen

Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

2015-08-27 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96725 --- Ship it! Ship It! - Joshua Cohen On Aug. 27, 2015, 6:01 p.m

Review Request 37956: Only process instances if there's been a change.

2015-08-31 Thread Joshua Cohen
with ~3000 instances, confirmed that memory usage did not grow beyond ~200MB. Thanks, Joshua Cohen

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread Joshua Cohen
files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png Thanks, Joshua Cohen

Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread Joshua Cohen
r an aborted update. Also see screenshot for tooltip changes. File Attachments Screen Shot 2015-09-01 at 12.08.51 PM.png https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png Thanks, Joshua Cohen

Review Request 38018: Fix link to update page for the update list.

2015-09-01 Thread Joshua Cohen
54bcdedf49ed852ab6eb0475250b81cb1ebc3b28 Diff: https://reviews.apache.org/r/38018/diff/ Testing --- Verified link goes directly to the update page. Thanks, Joshua Cohen

Review Request 38106: Make it possible to link directly to individual tabs on the job page.

2015-09-03 Thread Joshua Cohen
/scheduler/assets/js/app.js 310aa35c2ede799de693b86012e943fadfdf03f5 src/main/resources/scheduler/assets/js/controllers.js 98920196db34f2eb4dcad93429274517e7383efe Diff: https://reviews.apache.org/r/38106/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review97675 --- Ship it! Ship It! - Joshua Cohen On Sept. 3, 2015, 12:46 a.m

Re: Review Request 37956: Only process instances if there's been a change.

2015-09-02 Thread Joshua Cohen
://reviews.apache.org/r/37956/diff/ Testing --- Left tab open continually polling a job with ~3000 instances, confirmed that memory usage did not grow beyond ~200MB. Thanks, Joshua Cohen

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Joshua Cohen
/#review96394 --- On Aug. 25, 2015, 3:01 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761

  1   2   3   4   5   6   7   >