Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

2017-01-31 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56131/#review163714 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Jan. 31

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-01-25 Thread Santhosh Kumar Shanmugham
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review163003 --- On Jan. 25, 2017, 11:02 a.m., Santhosh Kumar Shanmugham wrote: > > ---

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-01-25 Thread Santhosh Kumar Shanmugham
, visit: https://reviews.apache.org/r/55951/#review163018 ------- On Jan. 25, 2017, 11:02 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically gener

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-01-25 Thread Santhosh Kumar Shanmugham
find any examples, so I will address, but will a while. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review163003 --------

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-01-25 Thread Santhosh Kumar Shanmugham
compatibility here, so users have to update to > > Thermos 0.18 (i.e. this patch) and Mesos 1.2 at the exact same time. > > > > I feel like we should escalate this and ask the Mesos people if they are > > willing to re-establish compatibility for one version. > &

Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-01-25 Thread Santhosh Kumar Shanmugham
/thermos/core/test_process.py 520390217f691b9136cb4d36262be3d372a16509 Diff: https://reviews.apache.org/r/55951/diff/ Testing --- build-support/jenkins/build.sh TBD: End-to-end test needs Mesos 1.2.0 which has not been released? Thanks, Santhosh Kumar Shanmugham

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-01-25 Thread Santhosh Kumar Shanmugham
compatible with the Mesos versions. - Santhosh Kumar Shanmugham On Jan. 25, 2017, 11:02 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56797: Move task conversion during reconciliation into the delayed closure.

2017-02-17 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56797/#review166013 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Feb. 17

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-12 Thread Santhosh Kumar Shanmugham
t237109> s/jobWithExpiredTasks/jobKeyToExpiredTasks/ src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java (line 147) <https://reviews.apache.org/r/56575/#comment237110> s/jobTasks/expiredTasks/ - Santhosh Kumar Shanmugham On Feb. 11, 2017, 3:12 p.m., M

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-13 Thread Santhosh Kumar Shanmugham
> On Feb. 13, 2017, 8:48 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > lines 1128-1129 > > <https://reviews.apache.org/r/56629/diff/5/?file=1632842#file1632842line1128> > > >

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-13 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165448 --- Add entry in RELEASE-NOTES. - Santhosh Kumar Shanmugham On Feb

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-13 Thread Santhosh Kumar Shanmugham
il. To reply, visit: > https://reviews.apache.org/r/56629/ > --- > > (Updated Feb. 13, 2017, 8:28 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer > Manji. > > > Reposito

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-13 Thread Santhosh Kumar Shanmugham
/SchedulerThriftInterface.java (lines 1130 - 1134) <https://reviews.apache.org/r/56629/#comment237292> Limit needs to be applied at the Store, both `MemTaskStore` and `DBTaskStore` do not appear to use the `limit` and `offset` filters. We can fix this in another RB. - Santhosh Kumar Shanmugham

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-13 Thread Santhosh Kumar Shanmugham
mmand has the potential to hurt the Scheduler, should we make sure that atleast one of the filters is provided? Or force a minimum default limit to avoid operators from accidentally bringing down the scheduler?" - Santhosh Kumar Shanmugham On Feb. 13, 2017, 9:41 p.m., David McLaug

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-13 Thread Santhosh Kumar Shanmugham
ld use the `TaskStore.pruneHistory` implementation which might be more efficient. - Santhosh Kumar Shanmugham On Feb. 13, 2017, 8:28 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
compatibility here, so users have to update to > > Thermos 0.18 (i.e. this patch) and Mesos 1.2 at the exact same time. > > > > I feel like we should escalate this and ask the Mesos people if they are > > willing to re-establish compatibility for one version. > &

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
uf library we use (tied to the version in use by > > Mesos). I remember thinking the problem wasn't intractable though. Would > > you mind taking a swing at that now that the json object is more complex? > > Santhosh Kumar Shanmugham wrote: > I could not find any examples, so

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Santhosh Kumar Shanmugham
- On Feb. 14, 2017, 3:38 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56575/ > --- > > (Updated Feb. 14, 2017, 3:38 p.m.) > > &

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
quot;None", "rootfs": "/some/path/taskfs"} > > > > > > src/test/python/apache/thermos/core/test_process.py:364: AssertionError > > generated xml file: > > /home/jenkins

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
> On Jan. 25, 2017, 11:21 a.m., Joshua Cohen wrote: > > build-support/packer/build.sh, line 20 > > <https://reviews.apache.org/r/55951/diff/1/?file=1615256#file1615256line20> > > > > This should probably be reverted? > > Santhosh Kumar Shanmugham w

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review165660 --- @ReviewBot retry - Santhosh Kumar Shanmugham On Feb. 14, 2017

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-13 Thread Santhosh Kumar Shanmugham
- > > (Updated Feb. 13, 2017, 9:30 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Bugs: AURORA-1837 > https://issues.apache.org/jira/browse/AURORA-1837 > > > Repos

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-13 Thread Santhosh Kumar Shanmugham
generated e-mail. To reply, visit: > https://reviews.apache.org/r/56575/ > --- > > (Updated Feb. 13, 2017, 9:30 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Bugs: AURORA-18

Re: Review Request 56723: Add best effort pulse timestamp recovery.

2017-02-15 Thread Santhosh Kumar Shanmugham
/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java (line 288) <https://reviews.apache.org/r/56723/#comment237651> Do we really need an immutable copy here? It seems so wasteful. Can we get away with using `max`? - Santhosh Kumar Shanmugham On Feb. 15, 2017, 6 p.m., Zameer

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-31 Thread Santhosh Kumar Shanmugham
f `Metadata` structs? > > rather than a set of strings which is what this will currently pass? > > Santhosh Kumar Shanmugham wrote: > You are totally correct. Is there any way to make the python tests do > type-checking? > > This however makes the &q

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-31 Thread Santhosh Kumar Shanmugham
e368d7c0dfa5ebdb465c7f112416 > src/test/python/apache/aurora/client/cli/util.py > aac9f9c802e4ad1f06cee8cf3f56749760b33af5 > > Diff: https://reviews.apache.org/r/51384/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ./pants test src/test/python/apache/aurora/client/cli:cli > > > Thanks, > > Santhosh Kumar Shanmugham > >

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-31 Thread Santhosh Kumar Shanmugham
--- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./pants test src/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-31 Thread Santhosh Kumar Shanmugham
nerated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review147521 ------- On Aug. 31, 2016, 9:14 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This i

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-31 Thread Santhosh Kumar Shanmugham
aac9f9c802e4ad1f06cee8cf3f56749760b33af5 Diff: https://reviews.apache.org/r/51384/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./pants test src/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-31 Thread Santhosh Kumar Shanmugham
metadata it attached to the request." - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review147494 -------

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-06 Thread Santhosh Kumar Shanmugham
/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-31 Thread Santhosh Kumar Shanmugham
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./pants test src/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Santhosh Kumar Shanmugham
y (line 346) <https://reviews.apache.org/r/51662/#comment215512> Add "--batch_size" and "--type" options to usage. - Santhosh Kumar Shanmugham On Sept. 7, 2016, 2:08 p.m., Karthik Anantha Padmanabhan wrote: > > -

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Santhosh Kumar Shanmugham
> On Sept. 7, 2016, 2:45 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/aurora/admin/admin.py, line 342 > > <https://reviews.apache.org/r/51662/diff/4/?file=1493670#file1493670line342> > > > > 'default=0' here and the usage doc reads defa

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Santhosh Kumar Shanmugham
> On Sept. 7, 2016, 2:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > <https://reviews.apache.org/r/51662/diff/4/?file=1493667#file1493667line1209> > > > > Did we consider combi

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Santhosh Kumar Shanmugham
> On Sept. 7, 2016, 2:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > <https://reviews.apache.org/r/51662/diff/4/?file=1493667#file1493667line1209> > > > > Did we consider combi

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-07 Thread Santhosh Kumar Shanmugham
iew148035 --- On Sept. 6, 2016, 8:29 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-07 Thread Santhosh Kumar Shanmugham
min/admin.py (lines 340 - 341) <https://reviews.apache.org/r/51662/#comment215547> Consider using choices=['explicit', 'implicit'] to make it more robust. src/main/python/apache/aurora/admin/admin.py (line 342) <https://reviews.apache.org/r/51662/#comment215551> type=int ? - S

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-29 Thread Santhosh Kumar Shanmugham
are unable to deal with Metadata object. Any ideas around this would be welcome. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review147184 ------

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-29 Thread Santhosh Kumar Shanmugham
f `Metadata` structs? > > rather than a set of strings which is what this will currently pass? > > Santhosh Kumar Shanmugham wrote: > You are totally correct. Is there any way to make the python tests do > type-checking? > > This however makes the &q

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

2016-09-14 Thread Santhosh Kumar Shanmugham
k_id? (bad) or will it fail to register? > > (better). > > Santhosh Kumar Shanmugham wrote: > The restarting framework will be treated like a scheduler fail-over. > > Zameer Manji wrote: > The release notes in this patch says > > Update default value of

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

2016-09-14 Thread Santhosh Kumar Shanmugham
k_id? (bad) or will it fail to register? > > (better). > > Santhosh Kumar Shanmugham wrote: > The restarting framework will be treated like a scheduler fail-over. > > Zameer Manji wrote: > The release notes in this patch says > > Update default value of

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-14 Thread Santhosh Kumar Shanmugham
8-f9ab1d4fe86c@192.168.33.7:8083 Scheduler log: I0914 20:35:24.000 [Thread-10, MesosSchedulerImpl:151] Registered with ID value: "071c44a1-b4d4-4339-a727-03a79f725851- " , master: id: "848618fb-714d-4b00-ad80-950f6bdc70c6" ip: 119646400 port: 5050 pid: "master@192.168.33.7:5050" hostname: "aurora.local" version: "1.0.0" address { hostname: "aurora.local" ip: "192.168.33.7" port: 5050 } Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-14 Thread Santhosh Kumar Shanmugham
; vagrant@aurora:~$ aurora job status devcluster INFO] Retrieving jobs for role None INFO] Checking status of devcluster/www-data/prod/hello Active tasks (1): Task role: www-data, env: prod, name: hello, instance: 0, status: RUNNING on 192.168.33.7 CPU: 1.0 core(s), RAM: 128 MB, Disk: 128 MB events: 2016-09-15 00:08:36 PENDING: None 2016-09-15 00:08:37 ASSIGNED: None 2016-09-15 00:08:39 STARTING: Initializing sandbox. 2016-09-15 00:08:39 RUNNING: None Inactive tasks (0): Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-14 Thread Santhosh Kumar Shanmugham
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review148988 ------- On Sept. 14, 2016, 1:58 p.m., Santhosh Kumar Shanmugham wrote: > > ---

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-08 Thread Santhosh Kumar Shanmugham
> On Sept. 8, 2016, 11:43 a.m., Santhosh Kumar Shanmugham wrote: > > src/test/python/apache/aurora/admin/test_admin.py, line 285 > > <https://reviews.apache.org/r/51662/diff/7/?file=1494557#file1494557line285> > > > > Should this also be assert_called_once_

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-08 Thread Santhosh Kumar Shanmugham
ment215709> Should this also be assert_called_once_with(None) ? - Santhosh Kumar Shanmugham On Sept. 8, 2016, 10:27 a.m., Karthik Anantha Padmanabhan wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

2016-09-13 Thread Santhosh Kumar Shanmugham
97677f24a50963178a123b420d7ac136e4fde3fe Diff: https://reviews.apache.org/r/51874/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-13 Thread Santhosh Kumar Shanmugham
/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

2016-09-13 Thread Santhosh Kumar Shanmugham
---- On Sept. 13, 2016, 5:05 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51874/ > -

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

2016-09-13 Thread Santhosh Kumar Shanmugham
://reviews.apache.org/r/51874/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

2016-09-13 Thread Santhosh Kumar Shanmugham
://reviews.apache.org/r/51874/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

2016-09-13 Thread Santhosh Kumar Shanmugham
ps://reviews.apache.org/r/51874/#review148816 ------- On Sept. 13, 2016, 5:18 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Santhosh Kumar Shanmugham
Did you try to rollback to pre 0.15 scheduler while changing the > > framework name? Trying to see if we can drop this 'backwards incompatible' > > statement now. > > Santhosh Kumar Shanmugham wrote: > Tested "roll-forward" (to Aurora) and "roll-back"

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Santhosh Kumar Shanmugham
-11, MesosSchedulerImpl:151] Registered with ID value: "308d7661-6bb1-4936-86b4-a01158bfa06b-" vagrant@aurora:~$ aurora job status devcluster INFO] Retrieving jobs for role None INFO] Checking status of devcluster/www-data/prod/hello Active tasks (1): Task role: www-data, env: prod, name: hello, instance: 0, status: RUNNING on 192.168.33.7 CPU: 1.0 core(s), RAM: 128 MB, Disk: 128 MB events: 2016-09-15 00:08:36 PENDING: None 2016-09-15 00:08:37 ASSIGNED: None 2016-09-15 00:08:39 STARTING: Initializing sandbox. 2016-09-15 00:08:39 RUNNING: None Inactive tasks (0): Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Santhosh Kumar Shanmugham
Did you try to rollback to pre 0.15 scheduler while changing the > > framework name? Trying to see if we can drop this 'backwards incompatible' > > statement now. > > Santhosh Kumar Shanmugham wrote: > Tested "roll-forward" (to Aurora) and "roll-back"

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-09 Thread Santhosh Kumar Shanmugham
ns.get()); reconciler.triggerImplicitReconciliation(); assertEquals(6L, explicitRuns.get()); assertEquals(3L, implicitRuns.get()); - Santhosh Kumar Shanmugham On Sept. 9, 2016, 11:43 a.m., Karthik Anantha Padmanabhan

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Santhosh Kumar Shanmugham
> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote: > > Master (640f07b) is red with this patch. > > ./build-support/jenkins/build.sh > > > > # Create file stdout for capturing output. > > We can't use StringIO mock > > 

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-04 Thread Santhosh Kumar Shanmugham
b279b4f679cc6843e99806bcbf57350ba1c9a6e0 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c93be9b4b4c76186445ae13eb9424bbf9de9b202 Diff: https://reviews.apache.org/r/52479/diff/ Testing --- build-support/jenkins/build.sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
ure of the behavior. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151276 --- On Oct. 3, 2016, 7:0

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-04 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151449 --- @ReviewBot retry - Santhosh Kumar Shanmugham On Oct. 3, 2016

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-16 Thread Santhosh Kumar Shanmugham
4-a01158bfa06b-" vagrant@aurora:~$ aurora job status devcluster INFO] Retrieving jobs for role None INFO] Checking status of devcluster/www-data/prod/hello Active tasks (1): Task role: www-data, env: prod, name: hello, instance: 0, status: RUNNING on 192.168.33.7 CPU: 1.0 core(s), RAM: 128 MB, Disk: 128 MB events: 2016-09-15 00:08:36 PENDING: None 2016-09-15 00:08:37 ASSIGNED: None 2016-09-15 00:08:39 STARTING: Initializing sandbox. 2016-09-15 00:08:39 RUNNING: None Inactive tasks (0): Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-07 Thread Santhosh Kumar Shanmugham
ng sub-selects appear to help out in the throughput. Beyond 5000 metadata pairs the throughput flattens out to 1 op/sec. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-27 Thread Santhosh Kumar Shanmugham
--- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./pants test src/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-27 Thread Santhosh Kumar Shanmugham
/util.py aac9f9c802e4ad1f06cee8cf3f56749760b33af5 Diff: https://reviews.apache.org/r/51384/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./pants test src/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-27 Thread Santhosh Kumar Shanmugham
nerated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review147091 ------- On Aug. 27, 2016, 8:58 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This i

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-24 Thread Santhosh Kumar Shanmugham
-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./pants test src/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-24 Thread Santhosh Kumar Shanmugham
src/test/python/apache/aurora/client/cli:cli Thanks, Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-24 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review146699 --- @ReviewBot retry - Santhosh Kumar Shanmugham On Aug. 24, 2016

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread Santhosh Kumar Shanmugham
d email below your username in the > left-hand pane, like this: https://reviews.apache.org/users/jsirois/ > > > - John > > > --- > This is an a

Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
Diff: https://reviews.apache.org/r/52479/diff/ Testing --- build-support/jenkins/build.sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
/naming.py#L60 - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151205 --- On Oct. 3, 2016, 10:29 a.m.

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
this, we talked about > > having the docker registry to use by a trait of the cluster, was that not > > feasible? > > Santhosh Kumar Shanmugham wrote: > I totally agree. Unfortunately I could not find a way to make pystachio > work that way. There are two stages in the pa

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
this, we talked about > > having the docker registry to use by a trait of the cluster, was that not > > feasible? > > Santhosh Kumar Shanmugham wrote: > I totally agree. Unfortunately I could not find a way to make pystachio > work that way. There are two stages in the pa

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151294 --- @ReviewBot retry - Santhosh Kumar Shanmugham On Oct. 3, 2016

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
this, we talked about > > having the docker registry to use by a trait of the cluster, was that not > > feasible? > > Santhosh Kumar Shanmugham wrote: > I totally agree. Unfortunately I could not find a way to make pystachio > work that way. There are two stages in the pa

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
b279b4f679cc6843e99806bcbf57350ba1c9a6e0 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c93be9b4b4c76186445ae13eb9424bbf9de9b202 Diff: https://reviews.apache.org/r/52479/diff/ Testing --- build-support/jenkins/build.sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
this, we talked about > > having the docker registry to use by a trait of the cluster, was that not > > feasible? > > Santhosh Kumar Shanmugham wrote: > I totally agree. Unfortunately I could not find a way to make pystachio > work that way. There are two stages in the pa

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-10 Thread Santhosh Kumar Shanmugham
ing something here? volume_modes table is not referenced in any INSERTs or SELECT. src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java (line 40) <https://reviews.apache.org/r/52588/#comment220827> .setVolumes(volumes) ? - Santhosh Kumar Shanmugham On Oct. 7,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-26 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review153978 --- Ship it! LGTM - Santhosh Kumar Shanmugham On Oct. 26, 2016

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-25 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review153850 --- Ping! - Santhosh Kumar Shanmugham On Oct. 23, 2016, 10:14 p.m

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-27 Thread Santhosh Kumar Shanmugham
. @ReviewBot retry - Santhosh Kumar Shanmugham On Oct. 27, 2016, 3:21 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53620: Update vagrant to a working basebox.

2016-11-09 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53620/#review155504 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Nov. 9

Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-09 Thread Santhosh Kumar Shanmugham
/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-23 Thread Santhosh Kumar Shanmugham
Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152853 --- On Oct. 12, 2016, 9:41 p.m., Santhosh K

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-16 Thread Santhosh Kumar Shanmugham
to take `signal_running`. Note: `ChainedStatusChecker` will also need to be modified to use the consensus logic. Let me know what you think. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-17 Thread Santhosh Kumar Shanmugham
e returns STARTING we > > poll until > > we reach the previous states. > > > > What do you think about that? > > Zameer Manji wrote: > For example, we might make the `Announcer` prevent a task go into > `RUNNING` unless it is sucessfully announced

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-17 Thread Santhosh Kumar Shanmugham
See the discussion below. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53590/#review156122 --- On Nov. 17, 201

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-17 Thread Santhosh Kumar Shanmugham
with the job update sentence highlighted above, > > once it is extracted. Done. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53590/#review156124 --

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-16 Thread Santhosh Kumar Shanmugham
--- buils-support/jenkins/build.sh sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-15 Thread Santhosh Kumar Shanmugham
9cc6cec6633ee5973d8c9faa98ae24ab10cbeca4 Diff: https://reviews.apache.org/r/53590/diff/ Testing --- buils-support/jenkins/build.sh sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-15 Thread Santhosh Kumar Shanmugham
clarify the role of > > the callback? How many args is it supposed to have, when will it be called? > > etc. Done. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-15 Thread Santhosh Kumar Shanmugham
avoid one extra conditional (since numbers do not overflow in python). But its probably not worth it, since every access to `attempts` is already gated. Changed it now. - Santhosh Kumar --- This is an automatically generated e

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

2016-11-13 Thread Santhosh Kumar Shanmugham
nd deadline), we'll > > consider the deadline expired and thus the task failed before get a chance > > to run the third health check. Again, is that the desired outcome (a case > > can be made that your grace period should account for this...). Added logic to fail-fast when there

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-27 Thread Santhosh Kumar Shanmugham
rc/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java (lines 165 - 166) <https://reviews.apache.org/r/51993/#comment223549> Use direct object comparison instead of `toString()`, see `assertNearest(...)` for

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-27 Thread Santhosh Kumar Shanmugham
(line 73) <https://reviews.apache.org/r/51993/#comment223551> Use `pendingTask.get("name").asText()` instead? - Santhosh Kumar Shanmugham On Oct. 26, 2016, 6:01 p.m., Pradyumna Kaushik wrote: > > --- >

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-02 Thread Santhosh Kumar Shanmugham
. - Santhosh Kumar Shanmugham On Nov. 1, 2016, 10:44 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-01 Thread Santhosh Kumar Shanmugham
> I am new to binding helpers. Do you have a pointer for me to understand > > why we need both these lines? Bindings can be resolved from scratch or from a dictionary (which can be communicated over the network). Although there is no use for the latter, I am following the desi

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-01 Thread Santhosh Kumar Shanmugham
/52479/diff/ Testing --- build-support/jenkins/build.sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-02 Thread Santhosh Kumar Shanmugham
> On Nov. 1, 2016, 11:06 p.m., Santhosh Kumar Shanmugham wrote: > > Note to committer: This patch changes the packer build script. Please do not commit - fixing flakiness in the end-to-end. - Santhosh Kumar --- This is an auto

  1   2   3   4   >