s this sound?
- Zhitao Li
On Jan. 11, 2016, 8:22 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42126/
> --
1ef059b17d16d4f1594a19ff6422ea653a413359
Diff: https://reviews.apache.org/r/42177/diff/
Testing
---
Integration test script.
Thanks,
Zhitao Li
separate out the vagrant box's cpu and
memory between 'aurora-test' role and '*' and verified that jobs can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
examples/vagrant/upstart/mesos-master.conf
9d7491c08e14e3951b2fd2f74291a2009883c379
examples/vagrant/upstart/mesos-slave.conf
1ef059b17d16d4f1594a19ff6422ea653a413359
Diff: https://reviews.apache.org/r/42177/diff/
Testing
---
Integration test script.
Thanks,
Zhitao Li
java, line 110
> > <https://reviews.apache.org/r/42126/diff/2/?file=1192873#file1192873line110>
> >
> > I'd like to strive to remove `@VisibleForTesting` from all methods in
> > this class and make them `private`. It will likely require more
can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
separate out the vagrant box's cpu and
memory between 'aurora-test' role and '*' and verified that jobs can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
.
Thanks,
Zhitao Li
with new and existing unit test. I'll work on more integration
test once we decide that this is the proper direction.
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42126/#review114478
-------
On Jan. 14, 2016, 2:46 p.m., Zhitao Li wrote:
>
> ---
> This
, and a change in test actually picked
the behavior up.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42126/#review114287
---
Is this intentionally commented out?
>
> Zhitao Li wrote:
> Yes this is intentially removed. Old behavior of changing this `config`
> here resulted in `resources` in static final object `OFFER` not sufficient to
> be allocated, and I don't see any point to use a different exe
tests;
2. vagrant integration tests: I manually separate out the vagrant box's cpu and
memory between 'aurora-test' role and '*' and verified that jobs can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
integration tests: I manually separate out the vagrant box's cpu and
memory between 'aurora-test' role and '*' and verified that jobs can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
(line 85)
<https://reviews.apache.org/r/42126/#comment175155>
I noticed that this predicate is actually reversed (sorry for the bug).
Fixing in next update.
- Zhitao Li
On Jan. 13, 2016, 10:32 p.m., Zhitao Li
with old and new tests;
2. vagrant integration tests: I manually separate out the vagrant box's cpu and
memory between 'aurora-test' role and '*' and verified that jobs can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
t; > Suggest moving all static final fields to the top of this class.
Will do.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42126/#review114348
------
sit:
https://reviews.apache.org/r/42126/#review114353
---
On Jan. 14, 2016, 1:39 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To re
This does not read right to me. If it's empty, a framework will be
> > registered without any role at all.
>
> Bill Farner wrote:
> +1
>
> Zhitao Li wrote:
> Will fix to "`The Mesos role this framework will register as. If left
> empty, this framework
ease let me know if you think otherwise.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42126/#review114128
-------
and new tests;
2. vagrant integration tests: I manually separate out the vagrant box's cpu and
memory between 'aurora-test' role and '*' and verified that jobs can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
. vagrant integration tests: I manually separate out the vagrant box's cpu and
memory between 'aurora-test' role and '*' and verified that jobs can still be
launched (I can post the vagrant change in another follow upon request).
Thanks,
Zhitao Li
in another follow upon request).
Thanks,
Zhitao Li
Is this intentionally commented out?
>
> Zhitao Li wrote:
> Yes this is intentially removed. Old behavior of changing this `config`
> here resulted in `resources` in static final object `OFFER` not sufficient to
> be allocated, and I don't see any point to use a different exe
990/#comment177706>
Maybe mention the constant label prefix?
- Zhitao Li
On Jan. 27, 2016, 10:17 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116647
---
Ship it!
Ship It!
- Zhitao Li
On Jan. 27, 2016, 10:52 p.m
/MesosTaskFactory.java (line 77)
<https://reviews.apache.org/r/35990/#comment177708>
Hmm, I think this is missing a trailing dot.
- Zhitao Li
On Jan. 27, 2016, 10:17 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically g
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
f4f5cd77b6444c225ec960c7e2cf5349a80bd344
Diff: https://reviews.apache.org/r/43112/diff/
Testing
---
./pants test src/test/python/apache/aurora/executor:executor
Thanks,
Zhitao Li
URORA-1606
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117494
---
On Feb. 2, 2016, 10:13
and cluster-wise executor upgrade, announce might be broken.
Can I suggest to make this flag optional and no-op for the deprecation cycle
(max of one version or 90 days according to recent email conversations), then
remove this afterwards?
- Zhitao Li
On Jan. 26, 2016, 6:40 p.m., Bill Farner wrote
f4f5cd77b6444c225ec960c7e2cf5349a80bd344
Diff: https://reviews.apache.org/r/43112/diff/
Testing
---
./pants test src/test/python/apache/aurora/executor:executor
Thanks,
Zhitao Li
> On Feb. 2, 2016, 9:31 p.m., Zhitao Li wrote:
> > Sorry for coming to this only after it's committed, but I think this might
> > create trouble for operators during upgrade.
> >
> > Because the new executor will not understand the `--announce-enable` flag
> &
/main/python/apache/aurora/executor/bin/thermos_executor_main.py
f4f5cd77b6444c225ec960c7e2cf5349a80bd344
Diff: https://reviews.apache.org/r/43112/diff/
Testing
---
./pants test src/test/python/apache/aurora/executor:executor
Thanks,
Zhitao Li
: https://reviews.apache.org/r/42177/diff/
Testing
---
Integration test script.
Thanks,
Zhitao Li
t;Add support for running
docker tasks without (thermos) executor", unless there is additional work
planned in same diff.
- Zhitao Li
On March 11, 2016, 12:44 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generat
-44a7-a824-dd87ef5920f0",
"framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-",
"id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31648-31648]"
},
...
```
Thanks,
Zhitao Li
399-4f5e80668703",
"framework_id": "66d5ac1b-9243-4ef3-8016-40f19d079f5d-",
"id": "vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31499-31499, 31529-31529]"
},
...
```
Thanks,
Zhitao Li
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45177/#review127147
---
On April 5, 2016, 4:20 p.m., Zhitao Li wrote:
>
> ---
-4ef3-8016-40f19d079f5d-",
"id": "vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31499-31499, 31529-31529]"
},
...
```
Thanks,
Zhitao Li
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21
> > <https://reviews.apache.org/r/45177/diff/6/?file=1326033#file1326033line21>
> >
> > Curious, what do changes in this file ac
ty": "CLUSTER"
},
"executor_id":
"thermos-vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703",
"framework_id": "66d5ac1b-9243-4ef3-8016-40f19d079f5d-",
"id": "vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31499-31499, 31529-31529]"
},
...
```
Thanks,
Zhitao Li
t this
> > is still a beta feature).
> > However you should probably be aware of that. Maybe you could mention
> > it in the documentation.
Will mention this in document.
- Zhitao
---
This is an automatically generated e-m
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21
> > <https://reviews.apache.org/r/45177/diff/6/?file=1326033#file1326033line21>
> >
> > Curious, what do changes in this file ac
any detriment to just always populating `DiscoveryInfo`?
>
> Zhitao Li wrote:
> The only possible concern I have for now is that this would 1) generate
> more data to Mesos and master/slave might have higher memory pressure, and 2)
> Mesos endpoints like /state.json might be
il. To reply, visit:
https://reviews.apache.org/r/45177/#review126574
-----------
On March 31, 2016, 9:48 p.m., Zhitao Li wrote:
>
> ---
> This is an automat
framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-",
"id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31648-31648]"
},
...
```
Thanks,
Zhitao Li
quot;framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-",
"id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31648-31648]"
},
...
```
Thanks,
Zhitao Li
ra
scheduler process?
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45177/#review126428
---
On March 31, 2016, 7:52 p.m., Zhita
g the inverse notation here? This would be
> > `...` instead of
> > `...`? @benley made a simmilar
> > comment on the mailing list.
> >
> > What do you think?
>
> Zhitao Li wrote:
> I'll give this a try and test again, but I suspect curre
-44a7-a824-dd87ef5920f0",
"framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-",
"id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31648-31648]"
},
...
```
Thanks,
Zhitao Li
/common/sandbox.py
a172691e164cf64792f65f049d698f9758336542
src/test/python/apache/aurora/executor/common/test_sandbox.py
57ab39e2444100c3a689bb0ff745c62f7bc2f1a6
Diff: https://reviews.apache.org/r/51564/diff/
Testing
---
Thanks,
Zhitao Li
/sandbox.py
a172691e164cf64792f65f049d698f9758336542
src/test/python/apache/aurora/executor/common/test_sandbox.py
57ab39e2444100c3a689bb0ff745c62f7bc2f1a6
Diff: https://reviews.apache.org/r/51564/diff/
Testing
---
Thanks,
Zhitao Li
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51564/#review147681
---
On Sept. 2, 2016, 2:11 p.m., Zhitao Li wrote:
>
>
tps://reviews.apache.org/r/51664/#comment215206>
Add a sentence to indicate that:
`Otherwise, this user and its primary group has to exist in the image with
matching uid/gip`
- Zhitao Li
On Sept. 6, 2016, 7:18 p.m., Stephan Erb
> On Sept. 6, 2016, 8 p.m., Zhitao Li wrote:
> > docs/features/containers.md, lines 55-56
> > <https://reviews.apache.org/r/51664/diff/1/?file=1492106#file1492106line55>
> >
> > Add a sentence to indicate that:
> >
> > `Otherwise,
t value.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51564/#review147497
---
On Aug. 31, 2016, 8:56 p.m., Zhitao Li wrote:
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51746/#review148262
---
Ship it!
Ship It!
- Zhitao Li
On Sept. 8, 2016, 8:56 p.m
/common/health_checker.py (line 265)
<https://reviews.apache.org/r/51899/#comment216613>
nit on the name of `isolator`: `isolator` is already a well-defined concept
within Mesos, and it seems to me that this is not related to that. Maybe
consider naming this as `wrapped_fn`?
- Zhi
58 matches
Mail list logo
