Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32806/ --- (Updated April 9, 2015, 4:45 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-08 Thread Bill Farner
> On April 3, 2015, 9:13 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line > > 295 > > > > > > +newline before Done. - Bill

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-03 Thread Bill Farner
> On April 3, 2015, 5:15 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/HttpService.java, line 21 > > > > > > This seems like it's a Qualifier for HostAndPort rather than an > > interface

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32806/#review78802 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/JettyServe

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-03 Thread Kevin Sweeney
> On April 3, 2015, 10:15 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line > > 338 > > > > > > I know this is mirroring the existing behavior but this seems li

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-03 Thread Kevin Sweeney
> On April 3, 2015, 10:15 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/HttpService.java, line 21 > > > > > > This seems like it's a Qualifier for HostAndPort rather than an > > interfac

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-03 Thread Bill Farner
> On April 3, 2015, 5:15 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line > > 338 > > > > > > I know this is mirroring the existing behavior but this seems lik

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32806/#review78795 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/HttpServic

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32806/#review78760 --- Master (a7b95d9) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32806/ --- (Updated April 3, 2015, 3:06 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

2015-04-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32806/#review78758 --- Master (a7b95d9) is red with this patch. ./build-support/jenkins/b