Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

> On April 15, 2015, 6:48 p.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/executor/test_thermos_task_runner.py, lines > > 226-227 > > > > > > nit: our python style for continuations is: > > > >

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 15, 2015, 8:38 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review80210 --- Ship it! lgtm modulo the style nit below src/test/python/apache/a

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

> On April 14, 2015, 12:58 p.m., Stephan Erb wrote: > > Friendly ping. Anything still missing or is this ready to merge? I don't think anything is missing. Waiting on jcohen to also give a shipit. - Zameer --- This is an automatically g

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review80092 --- Friendly ping. Anything still missing or is this ready to merge? -

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review79833 --- Ship it! Ship It! - Zameer Manji On April 11, 2015, 2:52 p.m., S

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review79817 --- Ship it! Master (eb9e408) is green with this patch. ./build-suppo

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

> On April 10, 2015, 7:59 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/executor/test_thermos_task_runner.py, line 213 > > > > > > Patching private methods for testing is a smell and it hinders > > refac

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 11, 2015, 11:52 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 11, 2015, 11:52 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review78972 --- Ship it! Master (5587bce) is green with this patch. ./build-suppo

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review78968 --- @ReviewBot retry - Stephan Erb On April 6, 2015, 7:12 p.m., Steph

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review78949 --- Master (27a602d) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review78942 --- @ReviewBot retry - Stephan Erb On April 6, 2015, 7:12 p.m., Steph

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review78935 --- Master (27a602d) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review78933 --- The discusson on the mailinglist regarding [this issue](https://mai