Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83525 --- Master (be75c36) is red with this patch. ./build-support/jenkins/b

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/ --- (Updated May 12, 2015, 11:49 p.m.) Review request for Aurora, Joshua Cohen, Kev

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, > > lines 102-106 > > > > > > It'd be nice if this was extracted out to a higher level so it

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 12, 2015, 9:24 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 203 > > > > > > module Doh, missed that from a previous round. Fixed. - Bill -

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83494 --- Ship it! Master (759ef68) is green with this patch. ./build-suppo

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83487 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/DbMo

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/ --- (Updated May 12, 2015, 9:17 p.m.) Review request for Aurora, Joshua Cohen, Kevi

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 12, 2015, 8:09 p.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 265 > > > > > > This seems unrelated to the description in this diff. It is related, as we don't have a

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82623 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, > > lines 102-106 > > > > > > It'd be nice if this was extracted out to a higher level so it

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, > > lines 102-106 > > > > > > It'd be nice if this was extracted out to a higher level so it

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83306 --- Ship it! - Maxim Khutornenko On May 9, 2015, 5:53 p.m., Bill Farn

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83229 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/DbMo

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, > > lines 102-106 > > > > > > It'd be nice if this was extracted out to a higher level so it

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83158 --- Ship it! Master (1c09d58) is green with this patch. ./build-suppo

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/ --- (Updated May 9, 2015, 5:53 p.m.) Review request for Aurora, Joshua Cohen, Kevin

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, lines > > 207-208 > > > > > > Doesn't need to be javadoc. Filled out with a comment. > On Ma

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82915 --- src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82914 --- Ping? - Bill Farner On May 5, 2015, 6:21 p.m., Bill Farner wrote:

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82558 --- Ship it! Master (8a1c8bb) is green with this patch. ./build-suppo

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/ --- (Updated May 5, 2015, 6:21 p.m.) Review request for Aurora, Joshua Cohen, Kevin

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 3, 2015, 2:34 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, line > > 147 > > > > > > Copy paste error. Should be `db_storage_save_tasks`. Good catch! Fi

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review82344 --- src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.ja

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On April 28, 2015, 11:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, line > > 154 > > > > > > One perf improvement here could be avoiding deleting TaskCo

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On April 28, 2015, 11:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 131 > > > > > > This feels like a potential for flakiness. Why 5? Any reason agains

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On April 28, 2015, 11:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 131 > > > > > > This feels like a potential for flakiness. Why 5? Any reason agains

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review81885 --- src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review81875 --- Ship it! Master (32cd1d5) is green with this patch. ./build-suppo