Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.
> On May 6, 2015, 3:39 p.m., Maxim Khutornenko wrote: > > Mind explaining explaining the bug for everyone's benefit? > > Maxim Khutornenko wrote: > Never mind, found the answer in the attached ticket. Hard to notice > "index.remove(key, Tasks.id(task));" bundled with unrelated stats refactoring. Sorry, that was not intentional - just the easiest way i saw to add a test case. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33869/#review82683 --- On May 5, 2015, 11:16 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33869/ > --- > > (Updated May 5, 2015, 11:16 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1305 > https://issues.apache.org/jira/browse/AURORA-1305 > > > Repository: aurora > > > Description > --- > > In practice this amounts to little more than a space leak, but a bug > nonetheless. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 9c76fa58b52bacd182e87cc4ebebad6c19356a55 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > e3b13407cb6875489e50cf93212845eab7aacb89 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > be57c5ee9f0218ed9fabb54b3579ba03477c8930 > > src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java > d1f4026f2b3d1cba542f96cecc0fe490e9ec8132 > > Diff: https://reviews.apache.org/r/33869/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.
> On May 6, 2015, 3:39 p.m., Maxim Khutornenko wrote: > > Mind explaining explaining the bug for everyone's benefit? Never mind, found the answer in the attached ticket. Hard to notice "index.remove(key, Tasks.id(task));" bundled with unrelated stats refactoring. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33869/#review82683 --- On May 5, 2015, 11:16 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33869/ > --- > > (Updated May 5, 2015, 11:16 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1305 > https://issues.apache.org/jira/browse/AURORA-1305 > > > Repository: aurora > > > Description > --- > > In practice this amounts to little more than a space leak, but a bug > nonetheless. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 9c76fa58b52bacd182e87cc4ebebad6c19356a55 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > e3b13407cb6875489e50cf93212845eab7aacb89 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > be57c5ee9f0218ed9fabb54b3579ba03477c8930 > > src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java > d1f4026f2b3d1cba542f96cecc0fe490e9ec8132 > > Diff: https://reviews.apache.org/r/33869/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33869/#review82690 --- Ship it! Ship It! - Maxim Khutornenko On May 5, 2015, 11:16 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33869/ > --- > > (Updated May 5, 2015, 11:16 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1305 > https://issues.apache.org/jira/browse/AURORA-1305 > > > Repository: aurora > > > Description > --- > > In practice this amounts to little more than a space leak, but a bug > nonetheless. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 9c76fa58b52bacd182e87cc4ebebad6c19356a55 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > e3b13407cb6875489e50cf93212845eab7aacb89 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > be57c5ee9f0218ed9fabb54b3579ba03477c8930 > > src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java > d1f4026f2b3d1cba542f96cecc0fe490e9ec8132 > > Diff: https://reviews.apache.org/r/33869/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33869/#review82683 --- Mind explaining explaining the bug for everyone's benefit? - Maxim Khutornenko On May 5, 2015, 11:16 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33869/ > --- > > (Updated May 5, 2015, 11:16 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1305 > https://issues.apache.org/jira/browse/AURORA-1305 > > > Repository: aurora > > > Description > --- > > In practice this amounts to little more than a space leak, but a bug > nonetheless. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 9c76fa58b52bacd182e87cc4ebebad6c19356a55 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > e3b13407cb6875489e50cf93212845eab7aacb89 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > be57c5ee9f0218ed9fabb54b3579ba03477c8930 > > src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java > d1f4026f2b3d1cba542f96cecc0fe490e9ec8132 > > Diff: https://reviews.apache.org/r/33869/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33869/#review82614 --- Ship it! Master (751d65f) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 5, 2015, 11:16 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33869/ > --- > > (Updated May 5, 2015, 11:16 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1305 > https://issues.apache.org/jira/browse/AURORA-1305 > > > Repository: aurora > > > Description > --- > > In practice this amounts to little more than a space leak, but a bug > nonetheless. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 9c76fa58b52bacd182e87cc4ebebad6c19356a55 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > e3b13407cb6875489e50cf93212845eab7aacb89 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > be57c5ee9f0218ed9fabb54b3579ba03477c8930 > > src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java > d1f4026f2b3d1cba542f96cecc0fe490e9ec8132 > > Diff: https://reviews.apache.org/r/33869/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
