Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
> On May 8, 2015, 5:22 p.m., Bill Farner wrote: > > Ship It! Mind committing for me? - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83119 -

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83121 --- Ship it! Master (1c09d58) is green with this patch. ./build-suppo

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83119 --- Ship it! Ship It! - Bill Farner On May 9, 2015, 12:11 a.m., Joe

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83118 --- Ship it! Ship It! - Joshua Cohen On May 9, 2015, 12:11 a.m., Joe

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/ --- (Updated May 8, 2015, 5:11 p.m.) Review request for Aurora and Bill Farner. C

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
> On May 8, 2015, 1:23 p.m., Joshua Cohen wrote: > > build-support/release/verify-release-candidate, line 81 > > > > > > do we need to explicitly set this to /tmp? Won't it use TMPDIR by > > default? It would use TMPD

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83071 --- Ship it! Master (288f00b) is green with this patch. ./build-suppo

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83068 --- build-support/release/verify-release-candidate