Re: Review Request 34020: Normalize SLA stat names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
On July 5, 2015, 12:49 p.m., Stephan Erb wrote: The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110 Bill Farner wrote: Good call - are you planning to roll that into this patch? Yep, good idea, pulled that in as well. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90412 --- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
On July 8, 2015, 10:49 a.m., Stephan Erb wrote: Joe, have you tested this change in vagrant? I decided to change direction here, so we won't be changing stats names. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90933 --- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
On July 5, 2015, 7:49 p.m., Stephan Erb wrote: The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110 Good call - are you planning to roll that into this patch? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90412 --- On June 12, 2015, 11:18 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated June 12, 2015, 11:18 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated June 12, 2015, 4:18 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description (updated) --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review83302 --- As Maxim pointed out on the ticket, there is a compatibility concern that should be addressed. If you don't mind, i'd like to conclude that discussion before reviewing. - Bill Farner On May 9, 2015, 9:54 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated May 9, 2015, 9:54 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names This is going to change these metrics from `sla_role/env/job_job_uptime_50.00_sec` to `sla_role_env_job_job_uptime_50_00_sec` Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
