Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review86718 --- Ship it! Master (ed4415c) is green with this patch.

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Maxim Khutornenko
On June 4, 2015, 8:12 p.m., Kevin Sweeney wrote: src/test/java/org/apache/aurora/scheduler/http/H2ConsoleModuleIT.java, line 37 https://reviews.apache.org/r/34566/diff/3/?file=979284#file979284line37 Use a MediaType constant here. Done. On June 4, 2015, 8:12 p.m., Kevin

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/ --- (Updated June 4, 2015, 8:49 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/ --- (Updated June 4, 2015, 8:56 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review86706 --- Ship it! Master (ed4415c) is green with this patch.

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review86710 --- Ship it! Looks good, only style nits

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review86634 ---

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Joshua Cohen
On June 4, 2015, 4:36 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java, lines 78-80 https://reviews.apache.org/r/34566/diff/2/?file=977711#file977711line78 Why don't need this anymore? Er, ignore this, I

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/ --- (Updated June 4, 2015, 7:31 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Maxim Khutornenko
On June 4, 2015, 4:36 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, lines 136-141 https://reviews.apache.org/r/34566/diff/2/?file=977709#file977709line136 Do you foresee us exposing other authorized servlets in this

Re: Review Request 34566: Adding H2 management console.

2015-06-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review86711 --- Ship it! Ship It! - Joshua Cohen On June 4, 2015, 7:31 p.m.,

Re: Review Request 34566: Adding H2 management console.

2015-06-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review86495 --- Ship it! Master (ed4415c) is green with this patch.

Re: Review Request 34566: Adding H2 management console.

2015-06-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/ --- (Updated June 3, 2015, 10:08 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 34566: Adding H2 management console.

2015-05-22 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review84794 --- Ship it! Master (998993d) is green with this patch.

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review84821 --- Might be worth adding tests for the conditional startup of the

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Kevin Sweeney
On May 21, 2015, 4:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding