Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Kevin Sweeney
On May 21, 2015, 5:22 p.m., Joshua Cohen wrote: src/main/python/apache/aurora/client/api/__init__.py, line 114 https://reviews.apache.org/r/34570/diff/2/?file=968393#file968393line114 Do we care that we're going from an immutable to a mutable set with this change (here and

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86879 --- @ReviewBot retry - Joshua Cohen On May 21, 2015, 11:28 p.m.,

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86883 --- Master (a1f7b3d) is red with this patch.

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86878 --- Ship it! Presumably you'll need to rebase. - Joshua Cohen On

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86872 --- Ship it! Also LGTM pending jcohen's comment - Joe Smith On May

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84818 --- This patch does not apply cleanly on master (998993d), do you need

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84825 --- Master (998993d) is red with this patch.

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/ --- (Updated May 21, 2015, 4:28 p.m.) Review request for Aurora, Joshua Cohen and