Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-07-01 Thread Brian Wickman
On June 30, 2015, 12:18 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/executor/http_lifecycle.py, line 70 https://reviews.apache.org/r/35847/diff/5/?file=991685#file991685line70 Use Event.wait() instead? I believe it's implemented this way for the purposes of

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-07-01 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated July 1, 2015, 5:37 p.m.) Review request for Aurora, Brian Brazil and

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89829 --- Ship it! docs/configuration-reference.md (lines 442 - 444)

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-26 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89513 --- Ship it! Ship It! - Brian Brazil On June 24, 2015, 10:45 p.m.,

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-26 Thread Brian Brazil
On June 25, 2015, 10:14 a.m., Brian Brazil wrote: docs/configuration-reference.md, line 449 https://reviews.apache.org/r/35847/diff/5/?file=991681#file991681line449 If we're making this configurable, I think that we should make it apply to the healthcheck config too.

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-25 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89335 --- docs/configuration-reference.md (line 436)

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-25 Thread Brian Wickman
On June 25, 2015, 10:14 a.m., Brian Brazil wrote: docs/configuration-reference.md, line 449 https://reviews.apache.org/r/35847/diff/5/?file=991681#file991681line449 If we're making this configurable, I think that we should make it apply to the healthcheck config too.

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89252 --- src/main/python/apache/aurora/config/schema/base.py (line 48)

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
On June 24, 2015, 9:57 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/config/schema/base.py, line 48 https://reviews.apache.org/r/35847/diff/1/?file=991584#file991584line48 Convention is to not capitalize acronyms like HTTP, but to render them as Http (here and below).

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated June 24, 2015, 9:55 p.m.) Review request for Aurora, Brian Brazil and

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89270 --- Master (d28bd4f) is red with this patch.

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Bill Farner
On June 24, 2015, 10:14 p.m., Bill Farner wrote: FYI i've raised a mailing list discussion questioning whether we should continue this abstraction. Figured i'd drop a note here in case it changes the shape of this patch. Brian Wickman wrote: If we didn't have the abstraction,

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89258 --- Master (d28bd4f) is red with this patch.

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated June 24, 2015, 10:45 p.m.) Review request for Aurora, Brian Brazil

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89262 --- FYI i've raised a mailing list discussion questioning whether we

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated June 24, 2015, 10:13 p.m.) Review request for Aurora, Brian Brazil

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89282 --- Ship it! Master (d28bd4f) is green with this patch.