Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review117480 --- Ship it! Master (3fc9dc2) is green with this patch.

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/ --- (Updated Feb. 2, 2016, 9:50 p.m.) Review request for Aurora, Bill Farner,

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Stephan Erb
> On Feb. 1, 2016, 11:04 nachm., Bill Farner wrote: > > My apologies for the delay, there is now a merge conflict in `NEWS`. Can > > you address? Yeah, I can rebase but will take me another 24h - Stephan --- This is an automatically

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review117281 --- My apologies for the delay, there is now a merge conflict in

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review117280 --- Ship it! Ship It! - Bill Farner On Jan. 27, 2016, 2:52

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/ --- (Updated Jan. 27, 2016, 11:17 p.m.) Review request for Aurora, Bill Farner,

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116637 --- Ship it! NEWS (line 45)

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116647 --- Ship it! Ship It! - Zhitao Li On Jan. 27, 2016, 10:52 p.m.,

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116643 --- Ship it! Master (c417f9d) is green with this patch.

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116650 --- Ship it! Master (e240fdc) is green with this patch.

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/ --- (Updated Jan. 27, 2016, 11:52 p.m.) Review request for Aurora, Bill Farner,

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Stephan Erb
> On Jan. 27, 2016, 11:31 p.m., Zhitao Li wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 77 > > > > > > Hmm, I think this is missing a trailing dot. Uups, good catch. -

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-01-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116639 ---

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-05 Thread Stephan Erb
On July 1, 2015, 1:59 p.m., Stephan Erb wrote: For sake of transparency: Turns out not everyone thinks this is a great idea. For details, see: https://github.com/prometheus/mesos_exporter/issues/7 Bill Farner wrote: Would it be reasonable to impose namespacing of labels, and

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-01 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review90041 --- For sake of transparency: Turns out not everyone thinks this is a

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-01 Thread Bill Farner
On July 1, 2015, 11:59 a.m., Stephan Erb wrote: For sake of transparency: Turns out not everyone thinks this is a great idea. For details, see: https://github.com/prometheus/mesos_exporter/issues/7 Would it be reasonable to impose namespacing of labels, and expect the downstream

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Stephan Erb
On June 29, 2015, 5:55 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 244 https://reviews.apache.org/r/35990/diff/1/?file=994197#file994197line244 I have been thinking about using mesos task labels to record the aurora job

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/ --- (Updated June 30, 2015, 9:36 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review89961 --- Ship it! LGTM. - Zameer Manji On June 30, 2015, 12:36 p.m.,

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review89954 --- Ship it! Master (616ef10) is green with this patch.

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review89750 ---

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review89685 --- Ship it! Master (2ef6a05) is green with this patch.