Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36096/#review90523 --- Ship it! +1 to this tactical fix. Which APIs need to be changed to

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36096/#review90535 --- Ship it! Master (318b40d) is green with this patch.

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36096/ --- (Updated July 6, 2015, 6:42 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Bill Farner
On July 6, 2015, 6:31 p.m., Kevin Sweeney wrote: +1 to this tactical fix. Which APIs need to be changed to use slaveID instead of hostName as the canonical identifier for mesos slaves within aurora? I'd approach bottom-up, starting with `AttributeStore#getHostAttributes()`. Most

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36096/#review90068 --- Ship it! Master (616ef10) is green with this patch.