Re: Review Request 36387: Fix JDBC URL.
> On July 13, 2015, 10:09 p.m., Zameer Manji wrote: > > Is it not possible for an integration test to catch this issue? Not in a straightforward way. The ultimate outcome would be flakiness in tests, where the DB would auto-close early and subsequent queries would fail. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36387/#review91541 --- On July 10, 2015, 5:31 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36387/ > --- > > (Updated July 10, 2015, 5:31 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This was broken in https://reviews.apache.org/r/36357/ > > I don't have a good answer for how to test this that isn't a carbon copy of > the module code. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 49d8bcbccf3ae2df74099551fae42dbc5292b559 > > Diff: https://reviews.apache.org/r/36387/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 36387: Fix JDBC URL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36387/#review91541 --- Ship it! Is it not possible for an integration test to catch this issue? - Zameer Manji On July 9, 2015, 10:31 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36387/ > --- > > (Updated July 9, 2015, 10:31 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This was broken in https://reviews.apache.org/r/36357/ > > I don't have a good answer for how to test this that isn't a carbon copy of > the module code. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 49d8bcbccf3ae2df74099551fae42dbc5292b559 > > Diff: https://reviews.apache.org/r/36387/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 36387: Fix JDBC URL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36387/#review91269 --- Master (190daed) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 10, 2015, 5:31 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36387/ > --- > > (Updated July 10, 2015, 5:31 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This was broken in https://reviews.apache.org/r/36357/ > > I don't have a good answer for how to test this that isn't a carbon copy of > the module code. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 49d8bcbccf3ae2df74099551fae42dbc5292b559 > > Diff: https://reviews.apache.org/r/36387/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
