Re: Review Request 37379: Updating to Mesos 0.23.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- Added a note on Mesos runtime deps. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs (updated) - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
On Aug. 13, 2015, 4:53 p.m., Kevin Sweeney wrote: build-support/python/make-mesos-native-egg, line 119 https://reviews.apache.org/r/37379/diff/1/?file=1038066#file1038066line119 HTTPS? Maxim Khutornenko wrote: No htts endpoint exists. This hangs forever: ``` Resolving people.centos.org... 204.15.73.242 Connecting to people.centos.org|204.15.73.242|:443... ``` Hmm - upstream packages are also completely unsigned (http://people.centos.org/tru/devtools-2/readme) - perhaps drop a TODO to use signed packages when they become available. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95354 --- On Aug. 17, 2015, 11:37 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 11:37 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95613 --- NEWS (line 12) https://reviews.apache.org/r/37379/#comment150691 It won't necessarily be libcurl-nss (as the suffix will be dependent on which SSL provider libcurl was compiled with), I think it's sufficient to reference libcurl here. Rather than mention MesosExecutorDriver (an implementation detail) just mention the executor. Rather than reference a blob-link just reference docs/getting-started.md - the NEWS file is in the same repo. - Kevin Sweeney On Aug. 17, 2015, 11:37 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 11:37 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
On Aug. 13, 2015, 4:53 p.m., Kevin Sweeney wrote: src/test/sh/org/apache/aurora/e2e/Dockerfile, line 18 https://reviews.apache.org/r/37379/diff/1/?file=1038072#file1038072line18 Is this documented upstream or just because we use libcurl4-nss-dev in the egg builder script? Either way you can install just libcurl4-nss rather than the -dev version of the package. Maxim Khutornenko wrote: It's documented indirectly here: https://github.com/apache/mesos/blob/cd4173059489eae33ee0c578e1fd61f10fc45a66/support/jenkins_build.sh#L57 Were you successful at using libcurl4-nss without the -dev package? I imagine the difference is quite a bloated Docker image and would like this repo to reflect the minimum for the test to pass. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95354 --- On Aug. 17, 2015, 11:37 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 11:37 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95620 --- Ship it! Master (b6e2bc3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 17, 2015, 6:37 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
On Aug. 17, 2015, 7:03 p.m., Kevin Sweeney wrote: build-support/python/make-mesos-native-egg, line 122 https://reviews.apache.org/r/37379/diff/3/?file=1042218#file1042218line122 Have you tested this? You use the same heredoc delimiter EOS twice. LOL. It actually does work this way, though prints out a warning wanting EOF instead. Fixed. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95618 --- On Aug. 17, 2015, 6:37 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
On Aug. 17, 2015, 6:50 p.m., Kevin Sweeney wrote: NEWS, line 12 https://reviews.apache.org/r/37379/diff/2-3/?file=1039700#file1039700line12 It won't necessarily be libcurl-nss (as the suffix will be dependent on which SSL provider libcurl was compiled with), I think it's sufficient to reference libcurl here. Rather than mention MesosExecutorDriver (an implementation detail) just mention the executor. Rather than reference a blob-link just reference docs/getting-started.md - the NEWS file is in the same repo. It won't necessarily be libcurl-nss (as the suffix will be dependent on which SSL provider libcurl was compiled with), I think it's sufficient to reference libcurl here. Makes sense. Done. Rather than mention MesosExecutorDriver (an implementation detail) just mention the executor. Done. Rather than reference a blob-link just reference docs/getting-started.md - the NEWS file is in the same repo. This is actually a Mesos repo link. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95613 --- On Aug. 17, 2015, 6:37 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
On Aug. 13, 2015, 11:53 p.m., Kevin Sweeney wrote: build-support/python/make-mesos-native-egg, line 119 https://reviews.apache.org/r/37379/diff/1/?file=1038066#file1038066line119 HTTPS? Maxim Khutornenko wrote: No htts endpoint exists. This hangs forever: ``` Resolving people.centos.org... 204.15.73.242 Connecting to people.centos.org|204.15.73.242|:443... ``` Kevin Sweeney wrote: Hmm - upstream packages are also completely unsigned (http://people.centos.org/tru/devtools-2/readme) - perhaps drop a TODO to use signed packages when they become available. Done. On Aug. 13, 2015, 11:53 p.m., Kevin Sweeney wrote: src/test/sh/org/apache/aurora/e2e/Dockerfile, line 18 https://reviews.apache.org/r/37379/diff/1/?file=1038072#file1038072line18 Is this documented upstream or just because we use libcurl4-nss-dev in the egg builder script? Either way you can install just libcurl4-nss rather than the -dev version of the package. Maxim Khutornenko wrote: It's documented indirectly here: https://github.com/apache/mesos/blob/cd4173059489eae33ee0c578e1fd61f10fc45a66/support/jenkins_build.sh#L57 Kevin Sweeney wrote: Were you successful at using libcurl4-nss without the -dev package? I imagine the difference is quite a bloated Docker image and would like this repo to reflect the minimum for the test to pass. There is no `libcurl4-nss` package available. Even if there was, I'd prefer going directly after Mesos-defined deps in our unit tests to better comply with current and future use cases. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95354 --- On Aug. 17, 2015, 6:37 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 17, 2015, 8:02 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- Kevin's comments Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs (updated) - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95354 --- NEWS (line 11) https://reviews.apache.org/r/37379/#comment150266 Replace with Upgraded mesos to 0.23.0 build-support/python/make-mesos-native-egg (line 119) https://reviews.apache.org/r/37379/#comment150267 HTTPS? src/test/sh/org/apache/aurora/e2e/Dockerfile (line 18) https://reviews.apache.org/r/37379/#comment150268 Is this documented upstream or just because we use libcurl4-nss-dev in the egg builder script? Either way you can install just libcurl4-nss rather than the -dev version of the package. - Kevin Sweeney On Aug. 11, 2015, 9:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 11, 2015, 9:58 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
On Aug. 13, 2015, 11:53 p.m., Kevin Sweeney wrote: NEWS, line 11 https://reviews.apache.org/r/37379/diff/1/?file=1038065#file1038065line11 Replace with Upgraded mesos to 0.23.0 Done. On Aug. 13, 2015, 11:53 p.m., Kevin Sweeney wrote: build-support/python/make-mesos-native-egg, line 119 https://reviews.apache.org/r/37379/diff/1/?file=1038066#file1038066line119 HTTPS? No htts endpoint exists. This hangs forever: ``` Resolving people.centos.org... 204.15.73.242 Connecting to people.centos.org|204.15.73.242|:443... ``` On Aug. 13, 2015, 11:53 p.m., Kevin Sweeney wrote: src/test/sh/org/apache/aurora/e2e/Dockerfile, line 18 https://reviews.apache.org/r/37379/diff/1/?file=1038072#file1038072line18 Is this documented upstream or just because we use libcurl4-nss-dev in the egg builder script? Either way you can install just libcurl4-nss rather than the -dev version of the package. It's documented indirectly here: https://github.com/apache/mesos/blob/cd4173059489eae33ee0c578e1fd61f10fc45a66/support/jenkins_build.sh#L57 - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95354 --- On Aug. 12, 2015, 4:58 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 12, 2015, 4:58 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 13, 2015, 11:59 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- Kevin's comments. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs (updated) - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 37379: Updating to Mesos 0.23.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95062 --- Ship it! Master (cbc42c4) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 12, 2015, 4:58 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 12, 2015, 4:58 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1429 https://issues.apache.org/jira/browse/AURORA-1429 Repository: aurora Description --- Updating to Mesos 0.23.0. A few notes: - Thermos executor fails to initialize MesosExecutorDriver unless libcurl4-nss-dev is installed. - Building Mesos now requires gcc 4.8, which is not available on centos6 via a standard repo. Diffs - 3rdparty/python/requirements.txt 4bc82b8b55ec14c8215e0bd67c4e68200ad9dbfc NEWS 6c0e20fe93e765dc84c3ba860cb8af5d565ba1ca build-support/python/make-mesos-native-egg fce53e42dde72b893f291db9d78af1dc47fafe2f build.gradle afb9b808a215eb5ff6e34ec6908c0e1ffbcd1991 docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d examples/vagrant/provision-dev-cluster.sh fc5388507deae3ea6f14eca3cd4cffd598e2422f src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 23c0e53b1a708843a9722c8bf1e8f0b739a9f5eb src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java aeb8946f8ebc58e6608557a0f277e382dc2667e5 src/test/sh/org/apache/aurora/e2e/Dockerfile e7f7f541e340c426b4e2a0f7a2c326af4bf902c2 Diff: https://reviews.apache.org/r/37379/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
