Re: Review Request 37872: Remove unused classes from commons fork.

2015-08-28 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37872/#review96898
---

Ship it!


Master (06ddaad) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 28, 2015, 5:15 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37872/
> ---
> 
> (Updated Aug. 28, 2015, 5:15 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Starting with low-hanging fruit - remove (almost exclusively) classes that 
> are unused.
> 
> 
> Diffs
> -
> 
>   build.gradle 9444886377bd7deb6a14604a50c8ed9cac90cdda 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java
>  6a48b84b3a04671498c012ecb7a31ace512b5394 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java
>  f786f9e028ce049cd55bf95bba86057e7abbaccb 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java
>  e2160e7d5c9db18bd2377ddabc03608e5143a72a 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java
>  d09631757a942f15337836fdea8fff30ec735233 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java
>  e4c58a21c1fdb2f12ce67efaaa888c33b48c 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/Registration.java
>  b66c8c8878001953422f9799cdd4545bdd931c51 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  b3e59e78b3f863cb352289ab2d3411c914d33264 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java
>  107e3aa51c7cf3729bb56800adece05742c55d30 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java
>  ba93d4c8f4707bd6ccb13e108216483625240698 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java
>  55236dfc53f4f842bc34b6d66d9fceeab39e4433 
>   commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 
> 3a1511dc8bf3651ccd91157db5716321485dfa5b 
>   
> commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java
>  b4f2d53293552164613119426993c5ae94558f1f 
>   commons/src/main/java/org/apache/aurora/common/base/Either.java 
> a746e72a95fee6e6108dbf0eead960f6a2227216 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java 
> e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java 
> f06c66cd027147903ea18ede9490c4c5c6ce122f 
>   commons/src/main/java/org/apache/aurora/common/base/SupplierE.java 
> ecad43e08e399db5b70b9f6b5fcdb401725b4efc 
>   commons/src/main/java/org/apache/aurora/common/collections/Bits.java 
> f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java
>  9cb6f547dfa470808def5d088984636a58dbf93c 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java
>  a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 
>   commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 
> 38fbe4dc692b51595499b392dcfb75af4b3edc44 
>   
> commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java
>  7543ff1dedc55897d7ec45d35be74caf42e74a56 
>   commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java 
> ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 
>   commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 
> 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 
>   commons/src/main/java/org/apache/aurora/common/io/Streamer.java 
> 902676036f1e50da7bd794ea23704bf6c5dc26c5 
>   commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java 
> a83895df65a399c1a85e421254d5e1ec167f4521 
>   commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 
> 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java
>  8a9e18e09e2184301af1c79f3027a380731451a3 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java
>  14bbd4cbb7cfeec6889f282c3fcb40dde008b600 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java
>  adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 
>   commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java 
> c5126dc4580d6e15222533071ec64bce529c8782 
>   commons/src/main/java/org/apache/aurora/common/n

Re: Review Request 37872: Remove unused classes from commons fork.

2015-08-28 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37872/
---

(Updated Aug. 28, 2015, 10:15 a.m.)


Review request for Aurora and Zameer Manji.


Changes
---

removed unused mockito dep, restored previoiusly-ignored test case in 
ServerSetImplTest.


Repository: aurora


Description
---

Starting with low-hanging fruit - remove (almost exclusively) classes that are 
unused.


Diffs (updated)
-

  build.gradle 9444886377bd7deb6a14604a50c8ed9cac90cdda 
  
commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java
 6a48b84b3a04671498c012ecb7a31ace512b5394 
  
commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java
 f786f9e028ce049cd55bf95bba86057e7abbaccb 
  
commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java
 e2160e7d5c9db18bd2377ddabc03608e5143a72a 
  
commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java
 d09631757a942f15337836fdea8fff30ec735233 
  
commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java
 e4c58a21c1fdb2f12ce67efaaa888c33b48c 
  
commons/src/main/java/org/apache/aurora/common/application/http/Registration.java
 b66c8c8878001953422f9799cdd4545bdd931c51 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 b3e59e78b3f863cb352289ab2d3411c914d33264 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java
 107e3aa51c7cf3729bb56800adece05742c55d30 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java
 ba93d4c8f4707bd6ccb13e108216483625240698 
  
commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java
 55236dfc53f4f842bc34b6d66d9fceeab39e4433 
  commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 
3a1511dc8bf3651ccd91157db5716321485dfa5b 
  
commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java
 b4f2d53293552164613119426993c5ae94558f1f 
  commons/src/main/java/org/apache/aurora/common/base/Either.java 
a746e72a95fee6e6108dbf0eead960f6a2227216 
  commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java 
e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 
  commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java 
f06c66cd027147903ea18ede9490c4c5c6ce122f 
  commons/src/main/java/org/apache/aurora/common/base/SupplierE.java 
ecad43e08e399db5b70b9f6b5fcdb401725b4efc 
  commons/src/main/java/org/apache/aurora/common/collections/Bits.java 
f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 
  
commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java
 9cb6f547dfa470808def5d088984636a58dbf93c 
  
commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java
 a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 
  commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 
38fbe4dc692b51595499b392dcfb75af4b3edc44 
  
commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java 
7543ff1dedc55897d7ec45d35be74caf42e74a56 
  commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java 
ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 
  commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 
1b955dbaccedebb644c7c57e0fc94dbff14e08c3 
  commons/src/main/java/org/apache/aurora/common/io/Streamer.java 
902676036f1e50da7bd794ea23704bf6c5dc26c5 
  commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java 
a83895df65a399c1a85e421254d5e1ec167f4521 
  commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 
5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d 
  
commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java
 8a9e18e09e2184301af1c79f3027a380731451a3 
  
commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java
 14bbd4cbb7cfeec6889f282c3fcb40dde008b600 
  
commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java
 adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 
  commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java 
c5126dc4580d6e15222533071ec64bce529c8782 
  commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java 
fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2 
  commons/src/main/java/org/apache/aurora/common/net/UrlHelper.java 
3f06d6335074119fa4a3dd3e364eaa9e69396b03 
  commons/src/main/java/org/apache/aurora/common/net/UrlResolver.java 
96c5f072b62ba74f3a96239a0069180f720bc200 
  commons/src/main/java/org/apache/aurora/common/net/UrlResolverUtil.java 
4b95bb7655cb86a6001b346df7bc66619b276ac8 
  commons/src/main/java/org/apache/aurora/common/net/UrlTokenizerUtil.java 
67798a3203e24b88da2403393a042fbd1d3df0ba 
  
commons/src/main/java/org/apache/aurora/comm

Re: Review Request 37872: Remove unused classes from commons fork.

2015-08-28 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37872/#review96889
---

Ship it!


Ship It!

- Zameer Manji


On Aug. 27, 2015, 9:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37872/
> ---
> 
> (Updated Aug. 27, 2015, 9:46 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Starting with low-hanging fruit - remove (almost exclusively) classes that 
> are unused.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java
>  6a48b84b3a04671498c012ecb7a31ace512b5394 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java
>  f786f9e028ce049cd55bf95bba86057e7abbaccb 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java
>  e2160e7d5c9db18bd2377ddabc03608e5143a72a 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java
>  d09631757a942f15337836fdea8fff30ec735233 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java
>  e4c58a21c1fdb2f12ce67efaaa888c33b48c 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/Registration.java
>  b66c8c8878001953422f9799cdd4545bdd931c51 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  b3e59e78b3f863cb352289ab2d3411c914d33264 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java
>  107e3aa51c7cf3729bb56800adece05742c55d30 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java
>  ba93d4c8f4707bd6ccb13e108216483625240698 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java
>  55236dfc53f4f842bc34b6d66d9fceeab39e4433 
>   commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 
> 3a1511dc8bf3651ccd91157db5716321485dfa5b 
>   
> commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java
>  b4f2d53293552164613119426993c5ae94558f1f 
>   commons/src/main/java/org/apache/aurora/common/base/Either.java 
> a746e72a95fee6e6108dbf0eead960f6a2227216 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java 
> e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java 
> f06c66cd027147903ea18ede9490c4c5c6ce122f 
>   commons/src/main/java/org/apache/aurora/common/base/SupplierE.java 
> ecad43e08e399db5b70b9f6b5fcdb401725b4efc 
>   commons/src/main/java/org/apache/aurora/common/collections/Bits.java 
> f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java
>  9cb6f547dfa470808def5d088984636a58dbf93c 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java
>  a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 
>   commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 
> 38fbe4dc692b51595499b392dcfb75af4b3edc44 
>   
> commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java
>  7543ff1dedc55897d7ec45d35be74caf42e74a56 
>   commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java 
> ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 
>   commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 
> 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 
>   commons/src/main/java/org/apache/aurora/common/io/Streamer.java 
> 902676036f1e50da7bd794ea23704bf6c5dc26c5 
>   commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java 
> a83895df65a399c1a85e421254d5e1ec167f4521 
>   commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 
> 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java
>  8a9e18e09e2184301af1c79f3027a380731451a3 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java
>  14bbd4cbb7cfeec6889f282c3fcb40dde008b600 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java
>  adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 
>   commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java 
> c5126dc4580d6e15222533071ec64bce529c8782 
>   commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java 
> fa474b5b3ef2a0e3e1e9c74ad4d6990ba65073b2 
>   commons/src/main/java/org/apache/aurora/common/net/UrlHelper.java 
> 3f06d6335074119fa4a3dd3e364eaa9e69396b03 
>   commons/src/main/java/org/apache/a

Re: Review Request 37872: Remove unused classes from commons fork.

2015-08-28 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37872/#review96886
---


Since you deleted 
commons/src/main/java/org/apache/aurora/common/testing/mockito/MockitoTest.java 
would you mind changing build.gradle and removing the dependency on mockito and 
objenesis dependency?

- Zameer Manji


On Aug. 27, 2015, 9:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37872/
> ---
> 
> (Updated Aug. 27, 2015, 9:46 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Starting with low-hanging fruit - remove (almost exclusively) classes that 
> are unused.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java
>  6a48b84b3a04671498c012ecb7a31ace512b5394 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java
>  f786f9e028ce049cd55bf95bba86057e7abbaccb 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java
>  e2160e7d5c9db18bd2377ddabc03608e5143a72a 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java
>  d09631757a942f15337836fdea8fff30ec735233 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java
>  e4c58a21c1fdb2f12ce67efaaa888c33b48c 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/Registration.java
>  b66c8c8878001953422f9799cdd4545bdd931c51 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  b3e59e78b3f863cb352289ab2d3411c914d33264 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java
>  107e3aa51c7cf3729bb56800adece05742c55d30 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java
>  ba93d4c8f4707bd6ccb13e108216483625240698 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java
>  55236dfc53f4f842bc34b6d66d9fceeab39e4433 
>   commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 
> 3a1511dc8bf3651ccd91157db5716321485dfa5b 
>   
> commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java
>  b4f2d53293552164613119426993c5ae94558f1f 
>   commons/src/main/java/org/apache/aurora/common/base/Either.java 
> a746e72a95fee6e6108dbf0eead960f6a2227216 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java 
> e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java 
> f06c66cd027147903ea18ede9490c4c5c6ce122f 
>   commons/src/main/java/org/apache/aurora/common/base/SupplierE.java 
> ecad43e08e399db5b70b9f6b5fcdb401725b4efc 
>   commons/src/main/java/org/apache/aurora/common/collections/Bits.java 
> f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java
>  9cb6f547dfa470808def5d088984636a58dbf93c 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java
>  a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 
>   commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 
> 38fbe4dc692b51595499b392dcfb75af4b3edc44 
>   
> commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java
>  7543ff1dedc55897d7ec45d35be74caf42e74a56 
>   commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java 
> ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 
>   commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 
> 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 
>   commons/src/main/java/org/apache/aurora/common/io/Streamer.java 
> 902676036f1e50da7bd794ea23704bf6c5dc26c5 
>   commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java 
> a83895df65a399c1a85e421254d5e1ec167f4521 
>   commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 
> 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java
>  8a9e18e09e2184301af1c79f3027a380731451a3 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java
>  14bbd4cbb7cfeec6889f282c3fcb40dde008b600 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java
>  adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 
>   commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java 
> c5126dc4580d6e15222533071ec64bce529c8782 
>   commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java 
> fa474b5b3ef

Re: Review Request 37872: Remove unused classes from commons fork.

2015-08-27 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37872/#review96834
---

Ship it!


Master (06ddaad) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 28, 2015, 4:46 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37872/
> ---
> 
> (Updated Aug. 28, 2015, 4:46 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Starting with low-hanging fruit - remove (almost exclusively) classes that 
> are unused.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/DefaultQuitHandler.java
>  6a48b84b3a04671498c012ecb7a31ace512b5394 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/GraphViewer.java
>  f786f9e028ce049cd55bf95bba86057e7abbaccb 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpAssetConfig.java
>  e2160e7d5c9db18bd2377ddabc03608e5143a72a 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpFilterConfig.java
>  d09631757a942f15337836fdea8fff30ec735233 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/HttpServletConfig.java
>  e4c58a21c1fdb2f12ce67efaaa888c33b48c 
>   
> commons/src/main/java/org/apache/aurora/common/application/http/Registration.java
>  b66c8c8878001953422f9799cdd4545bdd931c51 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  b3e59e78b3f863cb352289ab2d3411c914d33264 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LogModule.java
>  107e3aa51c7cf3729bb56800adece05742c55d30 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsExportModule.java
>  ba93d4c8f4707bd6ccb13e108216483625240698 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/ThriftModule.java
>  55236dfc53f4f842bc34b6d66d9fceeab39e4433 
>   commons/src/main/java/org/apache/aurora/common/base/CachingSupplier.java 
> 3a1511dc8bf3651ccd91157db5716321485dfa5b 
>   
> commons/src/main/java/org/apache/aurora/common/base/CallableExceptionalSupplier.java
>  b4f2d53293552164613119426993c5ae94558f1f 
>   commons/src/main/java/org/apache/aurora/common/base/Either.java 
> a746e72a95fee6e6108dbf0eead960f6a2227216 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionTransporter.java 
> e5cb60dc6ba672e7936caaee38c9e9e728bbe6d3 
>   
> commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunctions.java 
> f06c66cd027147903ea18ede9490c4c5c6ce122f 
>   commons/src/main/java/org/apache/aurora/common/base/SupplierE.java 
> ecad43e08e399db5b70b9f6b5fcdb401725b4efc 
>   commons/src/main/java/org/apache/aurora/common/collections/Bits.java 
> f07e04a08f3a1a1ce43c0cea3ea55e22960bbfa2 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/bootstrap/BootstrapModule.java
>  9cb6f547dfa470808def5d088984636a58dbf93c 
>   
> commons/src/main/java/org/apache/aurora/common/common/webassets/jquery/JQueryModule.java
>  a8e4524e6b93eaf697a5986cf66ebc8c38a0f2c2 
>   commons/src/main/java/org/apache/aurora/common/inject/DefaultProvider.java 
> 38fbe4dc692b51595499b392dcfb75af4b3edc44 
>   
> commons/src/main/java/org/apache/aurora/common/inject/ProviderMethodModule.java
>  7543ff1dedc55897d7ec45d35be74caf42e74a56 
>   commons/src/main/java/org/apache/aurora/common/io/Base64ZlibCodec.java 
> ed36e2a0e5e4ff36de10434f7bbd65c2155f4f40 
>   commons/src/main/java/org/apache/aurora/common/io/JsonCodec.java 
> 1b955dbaccedebb644c7c57e0fc94dbff14e08c3 
>   commons/src/main/java/org/apache/aurora/common/io/Streamer.java 
> 902676036f1e50da7bd794ea23704bf6c5dc26c5 
>   commons/src/main/java/org/apache/aurora/common/logging/BufferedLog.java 
> a83895df65a399c1a85e421254d5e1ec167f4521 
>   commons/src/main/java/org/apache/aurora/common/logging/LogUtil.java 
> 5f97cb2684d136a30f77b2e6d3f8aa5ee3a0163d 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeHandler.java
>  8a9e18e09e2184301af1c79f3027a380731451a3 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLevelConverter.java
>  14bbd4cbb7cfeec6889f282c3fcb40dde008b600 
>   
> commons/src/main/java/org/apache/aurora/common/logging/julbridge/JULBridgeLogManager.java
>  adf1a83d4086fb0dce12cbd06df8e7c2898fbeb3 
>   commons/src/main/java/org/apache/aurora/common/net/ProxyAuthorizer.java 
> c5126dc4580d6e15222533071ec64bce529c8782 
>   commons/src/main/java/org/apache/aurora/common/net/ProxyConfig.java 
> fa474b5b3ef2a0e3e1e9c74ad4d6990ba650