Re: Review Request 37987: Remove unused components from the scheduler application stack.

2015-08-31 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37987/#review97234
---


Master (c8e65d3) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 1, 2015, 3:09 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37987/
> ---
> 
> (Updated Sept. 1, 2015, 3:09 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is a bunch of behavior that we don't exercise at all (e.g. BuildInfo) or 
> don't benefit from.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> b7c4665d51f0efeebabd58c978707397b45d275d 
>   
> commons/src/main/java/org/apache/aurora/common/application/AbstractApplication.java
>  afb36913ab34e7243fc2d21e7ed6326b09af56dc 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> c842f428667545ed7716471b0d29525d9133a620 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/AppLauncherModule.java
>  65e9250a83cfd0a70c91aa352d5d2896c4888ab0 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  6414208cdf31b203ad65ab4b859c69b09b8ef308 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LocalServiceRegistry.java
>  806951bf51deab679529c947b138f588daa1b93a 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  78d95121297e0bad7c6b596cf4bf5ad684efcd33 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> c290d32148b2878c68b8ee8bcffa5f1c529b2ce1 
>   
> commons/src/test/java/org/apache/aurora/common/application/AppLauncherTest.java
>  d8212409b5f4ab4ce515f563e89e5894385ce43d 
>   
> commons/src/test/java/org/apache/aurora/common/application/modules/LifecycleModuleTest.java
>  940607e13eec3083bdc6e81c49e00b8d5da630c6 
>   
> commons/src/test/java/org/apache/aurora/common/application/modules/LocalServiceRegistryTest.java
>  7f679cb30557ae5db86789736a30168e42983712 
>   
> commons/src/test/java/org/apache/aurora/common/application/modules/StartStatPollerTest.java
>  5860eabd3eda346722e0b478044d721228345911 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0c440b5cd5b939872c1ee05d048bf739bfa977cb 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 7f0cb5c7f30883982ea9388bf6a6195705dfdd75 
> 
> Diff: https://reviews.apache.org/r/37987/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 37987: Remove unused components from the scheduler application stack.

2015-08-31 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37987/#review97233
---

Ship it!


Ship It!

- Zameer Manji


On Aug. 31, 2015, 8:09 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37987/
> ---
> 
> (Updated Aug. 31, 2015, 8:09 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is a bunch of behavior that we don't exercise at all (e.g. BuildInfo) or 
> don't benefit from.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> b7c4665d51f0efeebabd58c978707397b45d275d 
>   
> commons/src/main/java/org/apache/aurora/common/application/AbstractApplication.java
>  afb36913ab34e7243fc2d21e7ed6326b09af56dc 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> c842f428667545ed7716471b0d29525d9133a620 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/AppLauncherModule.java
>  65e9250a83cfd0a70c91aa352d5d2896c4888ab0 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  6414208cdf31b203ad65ab4b859c69b09b8ef308 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LocalServiceRegistry.java
>  806951bf51deab679529c947b138f588daa1b93a 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  78d95121297e0bad7c6b596cf4bf5ad684efcd33 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> c290d32148b2878c68b8ee8bcffa5f1c529b2ce1 
>   
> commons/src/test/java/org/apache/aurora/common/application/AppLauncherTest.java
>  d8212409b5f4ab4ce515f563e89e5894385ce43d 
>   
> commons/src/test/java/org/apache/aurora/common/application/modules/LifecycleModuleTest.java
>  940607e13eec3083bdc6e81c49e00b8d5da630c6 
>   
> commons/src/test/java/org/apache/aurora/common/application/modules/LocalServiceRegistryTest.java
>  7f679cb30557ae5db86789736a30168e42983712 
>   
> commons/src/test/java/org/apache/aurora/common/application/modules/StartStatPollerTest.java
>  5860eabd3eda346722e0b478044d721228345911 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0c440b5cd5b939872c1ee05d048bf739bfa977cb 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 7f0cb5c7f30883982ea9388bf6a6195705dfdd75 
> 
> Diff: https://reviews.apache.org/r/37987/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>