Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

(Updated Sept. 11, 2015, 10:02 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

I discovered an issue with tearing down in the last patch, due to not 
consistently invoking both shutdown-related systems.  The latest draft 
addresses that.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 387e379a9c84d663f2af23e4760754a023219860 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
8047622e206c9827e5cd8e40152a278d495bd0ff 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
d0faf13e3f1e14b6e70d230fea0fb484f2105873 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 
  src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
2f8fc10278e291fb28011b86bfa7c83905c6307c 
  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
63716459a4e21aa035b683ad46ef0a31620cfd98 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner

Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

(Updated Sept. 11, 2015, 10:29 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Rebase.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 b0f2d068f6e4d8242c3e3a33396d90ce28b98e90 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
acca4b44eb58b48923cf63c9a3aa15b50f67f153 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
c58ce716716b9e8c6cff694eaf771f0959419cf3 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
d0faf13e3f1e14b6e70d230fea0fb484f2105873 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 
  src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
2f8fc10278e291fb28011b86bfa7c83905c6307c 
  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
63716459a4e21aa035b683ad46ef0a31620cfd98 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner

Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98627
---


This patch does not apply cleanly on master (1230029), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 11, 2015, 5:02 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 11, 2015, 5:02 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98297
---

Ship it!


Master (a5ac5b9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 10:24 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 9, 2015, 10:24 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Bill Farner 


> On Sept. 9, 2015, 2:39 p.m., Kevin Sweeney wrote:
> > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java,
> >  line 63
> > 
> >
> > Looks like Modules.combine is redundant here.

Thanks, removed.


> On Sept. 9, 2015, 2:39 p.m., Kevin Sweeney wrote:
> > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java,
> >  line 111
> > 
> >
> > Consider subclassing AbstractScheduledService instead

Good call!  That was a remarkably simple switch :-)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98274
---


On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98274
---

Ship it!



commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
(line 51)


Looks like Modules.combine is redundant here.



commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 (line 108)


Consider subclassing AbstractScheduledService instead


- Kevin Sweeney


On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98080
---

Ship it!


Master (2773826) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 8, 2015, 9:49 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 8, 2015, 9:49 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

(Updated Sept. 8, 2015, 2:49 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Rebase + ping.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 387e379a9c84d663f2af23e4760754a023219860 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
8047622e206c9827e5cd8e40152a278d495bd0ff 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98118
---


@ReviewBot retry

- Bill Farner


On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

(Updated Sept. 8, 2015, 4:21 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 387e379a9c84d663f2af23e4760754a023219860 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
8047622e206c9827e5cd8e40152a278d495bd0ff 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
d0faf13e3f1e14b6e70d230fea0fb484f2105873 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 
  src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
2f8fc10278e291fb28011b86bfa7c83905c6307c 
  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
63716459a4e21aa035b683ad46ef0a31620cfd98 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98137
---

Ship it!


I'm not very familiar with this code but after a careful review this LGTM.

- Zameer Manji


On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

(Updated Sept. 3, 2015, 4:38 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 387e379a9c84d663f2af23e4760754a023219860 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
8047622e206c9827e5cd8e40152a278d495bd0ff 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
1a25924d789295c5950947f5e302e1d1fbec68f2 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner

Re: Review Request 38014: Remove StartupRegistry.

2015-09-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review97698
---


This patch does not apply cleanly on master (9c0b1b2), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 3, 2015, 11:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 3, 2015, 11:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 1a25924d789295c5950947f5e302e1d1fbec68f2 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review97319
---


Reviewer notes


commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 


This is replaced by invoking the @AppStartup service manager in 
SchedulerMain.



commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 


This was moved to SchedulerMain



commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 


TimeSeriesRepositoryImpl is now a service



commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 


I don't think there's much value behind gating sampling here while shutting 
down.



src/main/java/org/apache/aurora/GuavaUtils.java (lines 115 - 124)


Moved this from AppModule, but i'm not convinced it's valuable.  It seems 
to suggest that we don't have confidence in logging elsewhere in the scheduler 
about why we are tearing down.



src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 


This is now done in SchedulerMain.


- Bill Farner


On Sept. 1, 2015, 11:42 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 1, 2015, 11:42 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 1a25924d789295c5950947f5e302e1d1fbec68f2 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review97322
---



src/main/java/org/apache/aurora/GuavaUtils.java (lines 114 - 124)


Rather than change the purpose of this class from a dumb adapter that makes 
`ServiceManager` mockable, consider adding a `Listener` to `ServiceManager` and 
overriding `stopped`. This fits the canonical example of ServiceManager API 
usage.



src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 


Is this shutdown timeout preserved anywhere? Seems this should move to a 
`Listener` on the below providers.


- Kevin Sweeney


On Sept. 1, 2015, 11:59 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 1, 2015, 11:59 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> e3e90e3e43744463a2f00552f0041d0d1945bd57 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 1a25924d789295c5950947f5e302e1d1fbec68f2 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/
---

(Updated Sept. 1, 2015, 11:59 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Addressing two regressions in the first patch.


Repository: aurora


Description
---

Remove StartupRegistry.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
78ed7d0aae50c976eba9045b17587258edc588b0 
  
commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java 
997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
  commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
80509010f37894108881d40cad9d8ade8610f309 
  
commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
 1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
  
commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
 3959ce3d688dd50399185925d91f0014fc1c43f9 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java 
6928e48073d152915ca42b6f46236b21c0882086 
  
commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 387e379a9c84d663f2af23e4760754a023219860 
  config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
  src/main/java/org/apache/aurora/GuavaUtils.java 
e3e90e3e43744463a2f00552f0041d0d1945bd57 
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
1077816b696c4d2e97aafa59900b6acf2adce064 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
6892a70042e25fd672475517325b4e4b69a0adab 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
8047622e206c9827e5cd8e40152a278d495bd0ff 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
1a25924d789295c5950947f5e302e1d1fbec68f2 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
cb38c3e047efac483445f43b941c7eea8862cc9c 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
3f045ff38d672266ce2e2bb26f729b0ca4657e81 

Diff: https://reviews.apache.org/r/38014/diff/


Testing
---

test suite
./gradlew run
end-to-end tests


Thanks,

Bill Farner