Re: Review Request 38106: Make it possible to link directly to individual tabs on the job page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/#review97678 --- Ship it! Ship It! - David McLaughlin On Sept. 3, 2015, 7:14 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38106/ > --- > > (Updated Sept. 3, 2015, 7:14 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: AURORA-696 > https://issues.apache.org/jira/browse/AURORA-696 > > > Repository: aurora > > > Description > --- > > Make it possible to link directly to individual tabs on the job page. > > > Diffs > - > > src/main/resources/scheduler/assets/job.html > bfe51ab71e443615510d60915a28109070ba3501 > src/main/resources/scheduler/assets/js/app.js > 310aa35c2ede799de693b86012e943fadfdf03f5 > src/main/resources/scheduler/assets/js/controllers.js > 98920196db34f2eb4dcad93429274517e7383efe > > Diff: https://reviews.apache.org/r/38106/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 38106: Make it possible to link directly to individual tabs on the job page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/#review97673 --- Ship it! Ship It! - Zameer Manji On Sept. 3, 2015, 12:14 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38106/ > --- > > (Updated Sept. 3, 2015, 12:14 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: AURORA-696 > https://issues.apache.org/jira/browse/AURORA-696 > > > Repository: aurora > > > Description > --- > > Make it possible to link directly to individual tabs on the job page. > > > Diffs > - > > src/main/resources/scheduler/assets/job.html > bfe51ab71e443615510d60915a28109070ba3501 > src/main/resources/scheduler/assets/js/app.js > 310aa35c2ede799de693b86012e943fadfdf03f5 > src/main/resources/scheduler/assets/js/controllers.js > 98920196db34f2eb4dcad93429274517e7383efe > > Diff: https://reviews.apache.org/r/38106/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
Re: Review Request 38106: Make it possible to link directly to individual tabs on the job page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/#review97669 --- Master (f3cbc39) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 3, 2015, 7:14 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38106/ > --- > > (Updated Sept. 3, 2015, 7:14 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: AURORA-696 > https://issues.apache.org/jira/browse/AURORA-696 > > > Repository: aurora > > > Description > --- > > Make it possible to link directly to individual tabs on the job page. > > > Diffs > - > > src/main/resources/scheduler/assets/job.html > bfe51ab71e443615510d60915a28109070ba3501 > src/main/resources/scheduler/assets/js/app.js > 310aa35c2ede799de693b86012e943fadfdf03f5 > src/main/resources/scheduler/assets/js/controllers.js > 98920196db34f2eb4dcad93429274517e7383efe > > Diff: https://reviews.apache.org/r/38106/diff/ > > > Testing > --- > > > Thanks, > > Joshua Cohen > >
