Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38202/#review98286
---

Ship it!


Ship It!

- Bill Farner


On Sept. 8, 2015, 8:33 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38202/
> ---
> 
> (Updated Sept. 8, 2015, 8:33 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace BoundedQueue with Guava's EvictingQueue.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/collections/BoundedQueue.java 
> 3e2d5fa7dd66db4a3c798334c68a92b707660618 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   
> commons/src/test/java/org/apache/aurora/common/collections/BoundedQueueTest.java
>  d6e3c211542e14406785ff200076f77ac1dc4823 
> 
> Diff: https://reviews.apache.org/r/38202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38202/#review98302
---

Ship it!


Master (a5ac5b9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 3:33 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38202/
> ---
> 
> (Updated Sept. 9, 2015, 3:33 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace BoundedQueue with Guava's EvictingQueue.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/collections/BoundedQueue.java 
> 3e2d5fa7dd66db4a3c798334c68a92b707660618 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   
> commons/src/test/java/org/apache/aurora/common/collections/BoundedQueueTest.java
>  d6e3c211542e14406785ff200076f77ac1dc4823 
> 
> Diff: https://reviews.apache.org/r/38202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38202/#review98149
---


Master (2773826) is red with this patch.
  ./build-support/jenkins/build.sh

 > self.update_and_expect_ok()
 
 
src/test/python/apache/aurora/client/api/test_updater.py:905: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
src/test/python/apache/aurora/client/api/test_updater.py:335: in 
update_and_expect_ok
 self.update_and_expect_response(ResponseCode.OK, 
instances)
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 self = 
 expected_code = 1, instances = None
 message = None
 
 def update_and_expect_response(self, 
expected_code, instances=None, message=None):
   resp = self._updater.update(instances)
 > assert expected_code == resp.responseCode, (
 'Expected response:%s Actual response:%s' % 
(expected_code, resp.responseCode))
 E AssertionError: Expected response:1 Actual 
response:2
 E assert 1 == 2
 E  +  where 2 = 
Response(details=[ResponseDetail(message='Aborting update without rollback! 
Fa...obMonitor.terminate() -> None')], result=None, responseCode=2, 
serverInfo=None).responseCode
 
 
src/test/python/apache/aurora/client/api/test_updater.py:339: AssertionError
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.api.updater.xml
 
 == 1 failed, 31 passed in 1.07 seconds 
===
 src.test.python.apache.aurora.client.api.updater   
 .   FAILURE
 src.test.python.apache.aurora.client.cli.config
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.cron  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.thermos.cli.commands.commands   
 .   SUCCESS
 src.test.python.apache.thermos.cli.common  
 .   SUCCESS
 src.test.python.apache.thermos.cli.main
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 3:33 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38202/
> ---
> 
> (Updated Sept. 9, 2015, 3:33 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace BoundedQueue with Guava's EvictingQueue.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/collections/BoundedQueue.java 
> 3e2d5fa7dd66db4a3c798334c68a92b707660618 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   
> commons/src/test/java/org/apache/aurora/common/collections/BoundedQueueTest.java
>  d6e3c211542e14406785ff200076f77ac1dc4823 
> 
> Diff: https://reviews.apache.org/r/38202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>