Re: Review Request 38288: Revert "Revert "Refer to shared task_configs table for job updates.""
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38288/#review98624 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 11, 2015, 3:57 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38288/ > --- > > (Updated Sept. 11, 2015, 3:57 a.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-647 > https://issues.apache.org/jira/browse/AURORA-647 > > > Repository: aurora > > > Description > --- > > This reverts commit a45952785ffad9c7146d79dcaced517bc70439d9. > > This is a revival of https://reviews.apache.org/r/37789/, which was reverted > in https://reviews.apache.org/r/38072/ > > The patch in this review was created by reverting the revert commit, with no > additional changes. > > > Diffs > - > > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 48bee5068db5aeacf181c76c4d3add71d045c8a9 > src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java > fd46c3f0718c7c60b7b80b903545490cd7727204 > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java > 02ea355539d6f56c1c861ac83293b649285f43f4 > > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java > 2f58357dd63c46eb69de6a6daedcf027712d7b2e > > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java > 9afc3f3fcdcc1b60af2207888993411a55984c8e > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java > PRE-CREATION > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 6ffb54f5beef332097fd5c2390b56873a82f0aa9 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > d971aa19982e6095fbf514714df670cabd523d9d > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > 4a09693774dee599c161b524ac9d0e388f027f82 > > Diff: https://reviews.apache.org/r/38288/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 38288: Revert "Revert "Refer to shared task_configs table for job updates.""
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38288/#review98561 --- Ship it! Master (4ee10b0) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 11, 2015, 3:57 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38288/ > --- > > (Updated Sept. 11, 2015, 3:57 a.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-647 > https://issues.apache.org/jira/browse/AURORA-647 > > > Repository: aurora > > > Description > --- > > This reverts commit a45952785ffad9c7146d79dcaced517bc70439d9. > > This is a revival of https://reviews.apache.org/r/37789/, which was reverted > in https://reviews.apache.org/r/38072/ > > The patch in this review was created by reverting the revert commit, with no > additional changes. > > > Diffs > - > > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 48bee5068db5aeacf181c76c4d3add71d045c8a9 > src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java > fd46c3f0718c7c60b7b80b903545490cd7727204 > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java > 02ea355539d6f56c1c861ac83293b649285f43f4 > > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java > 2f58357dd63c46eb69de6a6daedcf027712d7b2e > > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java > 9afc3f3fcdcc1b60af2207888993411a55984c8e > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java > PRE-CREATION > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 6ffb54f5beef332097fd5c2390b56873a82f0aa9 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > d971aa19982e6095fbf514714df670cabd523d9d > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > 4a09693774dee599c161b524ac9d0e388f027f82 > > Diff: https://reviews.apache.org/r/38288/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
