Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Maxim Khutornenko
> On Sept. 21, 2015, 10:12 p.m., Zameer Manji wrote: > > docs/resource-isolation.md, line 168 > > > > > > higher or equal priority. Negative: https://github.com/apache/aurora/blob/0070a5fd18c6f219a7fe66f327209b8dc2

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99842 --- Ship it! Master (1ff336e) is green with this patch. ./build-suppo

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99837 --- Ship it! LGTM modulo my nit below. docs/resource-isolation.md (li

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/ --- (Updated Sept. 21, 2015, 9:20 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Maxim Khutornenko
> On Sept. 16, 2015, 12:51 a.m., Bill Farner wrote: > > docs/resource-isolation.md, line 150 > > > > > > This doc is otherewise about machine-level resource isolation, so it > > seems like an odd match here. It see

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Stephan Erb
> On Sept. 16, 2015, 2:51 a.m., Bill Farner wrote: > > docs/configuration-tutorial.md, line 583 > > > > > > Woah, this is a new doc to me...seems significantly redundant with > > configuration-reference.md. All the

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99136 --- Overall content LGTM. Mostly nits about organization, and a request

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99134 --- Ship it! Master (44e4726) is green with this patch. ./build-suppo

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/ --- (Updated Sept. 16, 2015, 12:14 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Maxim Khutornenko
> On Sept. 15, 2015, 8:52 p.m., Stephan Erb wrote: > > Reading your changes, I have noticed that we are missing a canonical > > explanation of the quota feature. It is only explained via cross references > > from the production flag. A gentle high-level introduction (maybe here > > https://git

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99090 --- Reading your changes, I have noticed that we are missing a canonical

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99007 --- Ship it! Master (44e4726) is green with this patch. ./build-suppo