Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/#review99837
---

Ship it!


LGTM modulo my nit below.


docs/resource-isolation.md (line 164)


higher or equal priority.


- Zameer Manji


On Sept. 21, 2015, 2:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38385/
> ---
> 
> (Updated Sept. 21, 2015, 2:41 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1462
> https://issues.apache.org/jira/browse/AURORA-1462
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting dedicated job & quota relationship.
> 
> 
> Diffs
> -
> 
>   docs/README.md fe115dca4931adbae545243dd9195481eeb035a0 
>   docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
>   docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
> 
> Diff: https://reviews.apache.org/r/38385/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/#review99842
---

Ship it!


Master (1ff336e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 21, 2015, 9:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38385/
> ---
> 
> (Updated Sept. 21, 2015, 9:41 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1462
> https://issues.apache.org/jira/browse/AURORA-1462
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting dedicated job & quota relationship.
> 
> 
> Diffs
> -
> 
>   docs/README.md fe115dca4931adbae545243dd9195481eeb035a0 
>   docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
>   docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
> 
> Diff: https://reviews.apache.org/r/38385/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/
---

(Updated Sept. 21, 2015, 9:20 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Bill's comments.


Bugs: AURORA-1462
https://issues.apache.org/jira/browse/AURORA-1462


Repository: aurora


Description
---

Documenting dedicated job & quota relationship.


Diffs (updated)
-

  docs/README.md fe115dca4931adbae545243dd9195481eeb035a0 
  docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
  docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
  docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
  docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
  docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 

Diff: https://reviews.apache.org/r/38385/diff/


Testing
---

Private remote: 
https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs


Thanks,

Maxim Khutornenko

Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Stephan Erb]

> On Sept. 16, 2015, 2:51 a.m., Bill Farner wrote:
> > docs/configuration-tutorial.md, line 583
> > 
> >
> > Woah, this is a new doc to me...seems significantly redundant with 
> > configuration-reference.md.  All the more point to trim this down and point 
> > off to prose about preemption/quota.  Mind filing a ticket to make these 
> > two docs less redundant?

That ticket does already exist: https://issues.apache.org/jira/browse/AURORA-829


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/#review99136
---


On Sept. 16, 2015, 2:14 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38385/
> ---
> 
> (Updated Sept. 16, 2015, 2:14 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1462
> https://issues.apache.org/jira/browse/AURORA-1462
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting dedicated job & quota relationship.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
>   docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
> 
> Diff: https://reviews.apache.org/r/38385/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/#review99134
---

Ship it!


Master (44e4726) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 16, 2015, 12:14 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38385/
> ---
> 
> (Updated Sept. 16, 2015, 12:14 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1462
> https://issues.apache.org/jira/browse/AURORA-1462
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting dedicated job & quota relationship.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
>   docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
> 
> Diff: https://reviews.apache.org/r/38385/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/#review99136
---


Overall content LGTM.  Mostly nits about organization, and a request for a new 
section to raise the preemption topic to a more prominent location.


docs/client-commands.md (line 335)


Please linkify `dedicated`, that would go a long way to point towards 
context.  A quick skim turnedt his up as a potential target: 
https://github.com/apache/aurora/blob/master/docs/deploying-aurora-scheduler.md#dedicated-attribute



docs/configuration-reference.md (line 327)


Not sure why we had the 'warning' in the first place, but i think it should 
be removed.  There isn't really any harm that warrants that tone.  Second - the 
note about preemption would be _great_ in a separate mini-section near 
'Resource Quota'.  With that, you can trim this down quite a bit:

> Indicated whether this is a production job that will be preferred for 
preemption [link].

Then the new preemption section can draw the connection to quota.



docs/configuration-tutorial.md (line 583)


Woah, this is a new doc to me...seems significantly redundant with 
configuration-reference.md.  All the more point to trim this down and point off 
to prose about preemption/quota.  Mind filing a ticket to make these two docs 
less redundant?



docs/deploying-aurora-scheduler.md (line 212)


I think it's fine to omit this and let the 'Resource Quota' section stand 
on its own.  Without a pointer to context, this is difficult to piece together. 
 Perhaps this:

> See the section about resource quotas [link] to learn how quotas apply to 
dedicated jobs.



docs/resource-isolation.md (line 150)


This doc is otherewise about machine-level resource isolation, so it seems 
like an odd match here.  It seems to align well with content in this page: 
docs/deploying-aurora-scheduler.md.


- Bill Farner


On Sept. 15, 2015, 5:14 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38385/
> ---
> 
> (Updated Sept. 15, 2015, 5:14 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1462
> https://issues.apache.org/jira/browse/AURORA-1462
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting dedicated job & quota relationship.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
>   docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
> 
> Diff: https://reviews.apache.org/r/38385/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/
---

(Updated Sept. 16, 2015, 12:14 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

Stephan's comments.


Bugs: AURORA-1462
https://issues.apache.org/jira/browse/AURORA-1462


Repository: aurora


Description
---

Documenting dedicated job & quota relationship.


Diffs (updated)
-

  docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
  docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
  docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
  docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
  docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 

Diff: https://reviews.apache.org/r/38385/diff/


Testing
---

Private remote: 
https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs


Thanks,

Maxim Khutornenko

Re: Review Request 38385: Documenting dedicated job & quota relationship.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38385/#review99090
---


Reading your changes, I have noticed that we are missing a canonical 
explanation of the quota feature. It is only explained via cross references 
from the production flag. A gentle high-level introduction (maybe here 
https://github.com/apache/aurora/blob/master/docs/resource-isolation.md) would 
be really beneficial for beginners.

(This remark is orthogonal to the issue addressed in this review request, so 
feel free to dismiss it here)

- Stephan Erb


On Sept. 15, 2015, 1:50 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38385/
> ---
> 
> (Updated Sept. 15, 2015, 1:50 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1462
> https://issues.apache.org/jira/browse/AURORA-1462
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Documenting dedicated job & quota relationship.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md f91e5df0c19104a961aa9955478bf2d37a2aa7b6 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/configuration-tutorial.md d6e7c352e16964e19a41340cb03a016620c17f7d 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38385/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/tree/quota_dedicated_docs/docs
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>