Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review99133 --- Ship it! Ship It! - Bill Farner On Sept. 15, 2015, 12:56 p.m.,

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review99005 --- Ship it! Master (44e4726) is green with this patch.

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review99082 --- Ship it! Master (44e4726) is green with this patch.

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-15 Thread Jake Farrell
> On Sept. 15, 2015, 1:24 a.m., Bill Farner wrote: > > The default value wasn't a hack, but moving it to the end of the > > `TaskConfig` message definition was. I think the default is useful and > > should really remain. IIRC we concluded that the `optional` was > > unnecessary, though. > >

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review98979 --- The default value wasn't a hack, but moving it to the end of the