Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Maxim Khutornenko


> On Sept. 21, 2015, 9:48 p.m., Zameer Manji wrote:
> > docs/configuration-reference.md, line 355
> > 
> >
> > What happens if a job with a tier of revocable is sent to a scheduler 
> > where it isn't configured? I think that should be added here.

Added a clarification.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review99835
---


On Sept. 21, 2015, 9:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 21, 2015, 9:41 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/
---

(Updated Sept. 21, 2015, 10:36 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Zameer's comments.


Bugs: AURORA-1441
https://issues.apache.org/jira/browse/AURORA-1441


Repository: aurora


Description
---

Adding oversubscription summary.


Diffs (updated)
-

  docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
  docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 

Diff: https://reviews.apache.org/r/38390/diff/


Testing
---

Private remote: 
https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/


Thanks,

Maxim Khutornenko



Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Maxim Khutornenko


> On Sept. 15, 2015, 1:20 a.m., Bill Farner wrote:
> > docs/configuration-reference.md, lines 344-355
> > 
> >
> > Tiers seems like a significant enough topic to warrant its own page 
> > with some more context and better flow.  As it stands, it's really hard to 
> > understand what exactly a tier is and why i want or need to define them. 
> > 
> > Also, you might consider dropping the term 'best-effort' and stick to 
> > 'revocable' to avoid overloading the naming.
> 
> Maxim Khutornenko wrote:
> | Tiers seems like a significant enough topic to warrant its own page 
> with some more context and better flow.  As it stands, it's really hard to 
> understand what exactly a tier is and why i want or need to define them. 
> 
> Agree. I am hesitant to promote the `tier` concept though until we fully 
> conceptualize it in AURORA-1443. As it stands now, it only supports 
> `revocable` value and has zero meaning outside the revocable offer work. 
> 
> | Also, you might consider dropping the term 'best-effort' and stick to 
> 'revocable' to avoid overloading the naming.
> 
> Sure, works for me.
> 
> Bill Farner wrote:
> The intention is not to promote it (disclaimers are fine), but rather to 
> paint the picture and not leave the reader hanging.  Doesn't have to be a lot 
> of content, but some indication of how it fits in and the development status 
> would go a long way.

I am uncomfortable promoting a half-baked concept until the migration plan and 
implementation details are fully fleshed out. I feel that AURORA-1343 and 
AURORA-1443 linked above give enough additional info for curiously minded 
without restating the points already defined in the design doc (mentioned in 
the above tickets).


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review98977
---


On Sept. 16, 2015, 12:38 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 16, 2015, 12:38 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review99835
---

Ship it!


LGTM modulo my one nit.


docs/configuration-reference.md (line 355)


What happens if a job with a tier of revocable is sent to a scheduler where 
it isn't configured? I think that should be added here.


- Zameer Manji


On Sept. 21, 2015, 2:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 21, 2015, 2:41 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Maxim Khutornenko


> On Sept. 15, 2015, 1:20 a.m., Bill Farner wrote:
> > docs/configuration-reference.md, lines 344-355
> > 
> >
> > Tiers seems like a significant enough topic to warrant its own page 
> > with some more context and better flow.  As it stands, it's really hard to 
> > understand what exactly a tier is and why i want or need to define them. 
> > 
> > Also, you might consider dropping the term 'best-effort' and stick to 
> > 'revocable' to avoid overloading the naming.

| Tiers seems like a significant enough topic to warrant its own page with some 
more context and better flow.  As it stands, it's really hard to understand 
what exactly a tier is and why i want or need to define them. 

Agree. I am hesitant to promote the `tier` concept though until we fully 
conceptualize it in AURORA-1443. As it stands now, it only supports `revocable` 
value and has zero meaning outside the revocable offer work. 

| Also, you might consider dropping the term 'best-effort' and stick to 
'revocable' to avoid overloading the naming.

Sure, works for me.


> On Sept. 15, 2015, 1:20 a.m., Bill Farner wrote:
> > docs/configuration-reference.md, line 332
> > 
> >
> > This could use a more objective statement about what the flag _is_ 
> > rather than that it intends to be.

Done.


> On Sept. 15, 2015, 1:20 a.m., Bill Farner wrote:
> > docs/deploying-aurora-scheduler.md, line 201
> > 
> >
> > Would it make sense to remove this flag, and instead enable revocable 
> > resources when there's at least one configured tier that uses them?

I don't think we want to tie these together. We should be able to start/stop 
receiving revocable resources independent of the revocable tier presence. 
Modifying a tier config file to stop receiving mesos revocable offers is very 
confusing and error prone.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review98977
---


On Sept. 15, 2015, 12:54 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 15, 2015, 12:54 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Maxim Khutornenko


> On Sept. 15, 2015, 8:59 p.m., Stephan Erb wrote:
> > docs/configuration-reference.md, line 346
> > 
> >
> > How about attaching a date or version classifier here? Makes it much 
> > easier for a reader to understand if this is a valid concern or if the docu 
> > is just out of date (unfortunately that is rather common in many projects).

I'd avoid sprinkling a version over our docs to avoid additional maintenance 
burden. I.e. a version pointer can get stale very quickly when our release 
plans change.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review99091
---


On Sept. 15, 2015, 12:54 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 15, 2015, 12:54 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/
---

(Updated Sept. 16, 2015, 12:38 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

Bill's comments.


Bugs: AURORA-1441
https://issues.apache.org/jira/browse/AURORA-1441


Repository: aurora


Description
---

Adding oversubscription summary.


Diffs (updated)
-

  docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
  docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 

Diff: https://reviews.apache.org/r/38390/diff/


Testing
---

Private remote: 
https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/


Thanks,

Maxim Khutornenko



Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Bill Farner


> On Sept. 14, 2015, 6:20 p.m., Bill Farner wrote:
> > docs/configuration-reference.md, lines 344-355
> > 
> >
> > Tiers seems like a significant enough topic to warrant its own page 
> > with some more context and better flow.  As it stands, it's really hard to 
> > understand what exactly a tier is and why i want or need to define them. 
> > 
> > Also, you might consider dropping the term 'best-effort' and stick to 
> > 'revocable' to avoid overloading the naming.
> 
> Maxim Khutornenko wrote:
> | Tiers seems like a significant enough topic to warrant its own page 
> with some more context and better flow.  As it stands, it's really hard to 
> understand what exactly a tier is and why i want or need to define them. 
> 
> Agree. I am hesitant to promote the `tier` concept though until we fully 
> conceptualize it in AURORA-1443. As it stands now, it only supports 
> `revocable` value and has zero meaning outside the revocable offer work. 
> 
> | Also, you might consider dropping the term 'best-effort' and stick to 
> 'revocable' to avoid overloading the naming.
> 
> Sure, works for me.

The intention is not to promote it (disclaimers are fine), but rather to paint 
the picture and not leave the reader hanging.  Doesn't have to be a lot of 
content, but some indication of how it fits in and the development status would 
go a long way.


> On Sept. 14, 2015, 6:20 p.m., Bill Farner wrote:
> > docs/deploying-aurora-scheduler.md, line 201
> > 
> >
> > Would it make sense to remove this flag, and instead enable revocable 
> > resources when there's at least one configured tier that uses them?
> 
> Maxim Khutornenko wrote:
> I don't think we want to tie these together. We should be able to 
> start/stop receiving revocable resources independent of the revocable tier 
> presence. Modifying a tier config file to stop receiving mesos revocable 
> offers is very confusing and error prone.

I buy this for the state today, but it seems like this should change if we ever 
make explicit tier configuration required.  The current situation is 
error-prone since the cluster operator needs to be sure to flip two knobs to 
really 'enable' the feature.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review98977
---


On Sept. 15, 2015, 5:38 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 15, 2015, 5:38 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review99137
---

Ship it!


Master (44e4726) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 16, 2015, 12:38 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 16, 2015, 12:38 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review99006
---

Ship it!


Master (44e4726) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 15, 2015, 12:54 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 15, 2015, 12:54 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review99091
---



docs/configuration-reference.md (line 346)


How about attaching a date or version classifier here? Makes it much easier 
for a reader to understand if this is a valid concern or if the docu is just 
out of date (unfortunately that is rather common in many projects).


- Stephan Erb


On Sept. 15, 2015, 2:54 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 15, 2015, 2:54 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 38390: Adding oversubscription summary.

2015-09-14 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/
---

(Updated Sept. 15, 2015, 12:54 a.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1441
https://issues.apache.org/jira/browse/AURORA-1441


Repository: aurora


Description
---

Adding oversubscription summary.


Diffs (updated)
-

  docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
  docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 

Diff: https://reviews.apache.org/r/38390/diff/


Testing
---

Private remote: 
https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/


Thanks,

Maxim Khutornenko



Re: Review Request 38390: Adding oversubscription summary.

2015-09-14 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38390/#review98977
---



docs/configuration-reference.md (line 332)


This could use a more objective statement about what the flag _is_ rather 
than that it intends to be.



docs/configuration-reference.md (lines 344 - 355)


Tiers seems like a significant enough topic to warrant its own page with 
some more context and better flow.  As it stands, it's really hard to 
understand what exactly a tier is and why i want or need to define them. 

Also, you might consider dropping the term 'best-effort' and stick to 
'revocable' to avoid overloading the naming.



docs/deploying-aurora-scheduler.md (line 201)


Would it make sense to remove this flag, and instead enable revocable 
resources when there's at least one configured tier that uses them?


- Bill Farner


On Sept. 14, 2015, 5:54 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38390/
> ---
> 
> (Updated Sept. 14, 2015, 5:54 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1441
> https://issues.apache.org/jira/browse/AURORA-1441
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding oversubscription summary.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 
>   docs/deploying-aurora-scheduler.md 8db0e615b6abe6865a889dbcfb24271655caaee6 
> 
> Diff: https://reviews.apache.org/r/38390/diff/
> 
> 
> Testing
> ---
> 
> Private remote: 
> https://github.com/maxim111333/incubator-aurora/blob/oversubscription_docs/docs/
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>