Re: Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39095/#review101796
---

Ship it!


Master (d884680) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 7, 2015, 4:50 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39095/
> ---
> 
> (Updated Oct. 7, 2015, 4:50 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Gradle 2.7 was recently released [1].  It doesn't seem to add a whole lot for 
> us, but it does fix an impedance mismatch with recent versions of checkstyle. 
>  I've also upgraded to the latest checkstyle, which has significant changes 
> of interest, mostly around better lambda handling.  The code changes in this 
> diff are the result of improvements to the default 'redundant modifier' 
> check, and are legitimate.
> 
> [1] https://docs.gradle.org/2.7/release-notes
> [2] http://checkstyle.sourceforge.net/releasenotes.html
> 
> 
> Diffs
> -
> 
>   build.gradle 0401a9cbf0caf5578ef3c30e67c5b6a0a7a74a03 
>   buildSrc/gradle.properties bbfdeb20161f497775e36c4b144436253c37c9f0 
>   gradle/wrapper/gradle-wrapper.properties 
> 6475df2e93744193a635a22080d6c35a1523f4ea 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 
> 712876e1fe2bfb02cb147cd7674a84dd220de899 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 
> 9726a09f7a635bb137473a0ad0cc5ee6db77e6de 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
> cf1b91907fefb3b22dcd62a8ebaf2b756cec26d5 
>   src/main/java/org/apache/aurora/scheduler/spi/Permissions.java 
> c2919ab2b3dca3e3f8fcd095493816ad9b160d46 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 1be533b0b33f529eb345c60369bde98052d60100 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> e7be8e2198564a1d47a6b5121d7ad653db740fdc 
>   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 
> 8f1ee7d91b1dd529de85cf393ec1809b775fa3bb 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  14b5a00dea1a739b2b52e2e1b3b48eb987744760 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java 
> a329b078d18a0db7d2de5484ca79e3c703d5232e 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java
>  9ad9012b81db56c38e3a253dfce06622eae57690 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 2bca8bf4f31c19c1cc797959db4017efbfd8badb 
> 
> Diff: https://reviews.apache.org/r/39095/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39095/#review101791
---

Ship it!


Ship It!

- Joshua Cohen


On Oct. 7, 2015, 4:50 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39095/
> ---
> 
> (Updated Oct. 7, 2015, 4:50 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Gradle 2.7 was recently released [1].  It doesn't seem to add a whole lot for 
> us, but it does fix an impedance mismatch with recent versions of checkstyle. 
>  I've also upgraded to the latest checkstyle, which has significant changes 
> of interest, mostly around better lambda handling.  The code changes in this 
> diff are the result of improvements to the default 'redundant modifier' 
> check, and are legitimate.
> 
> [1] https://docs.gradle.org/2.7/release-notes
> [2] http://checkstyle.sourceforge.net/releasenotes.html
> 
> 
> Diffs
> -
> 
>   build.gradle 0401a9cbf0caf5578ef3c30e67c5b6a0a7a74a03 
>   buildSrc/gradle.properties bbfdeb20161f497775e36c4b144436253c37c9f0 
>   gradle/wrapper/gradle-wrapper.properties 
> 6475df2e93744193a635a22080d6c35a1523f4ea 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 
> 712876e1fe2bfb02cb147cd7674a84dd220de899 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 
> 9726a09f7a635bb137473a0ad0cc5ee6db77e6de 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
> cf1b91907fefb3b22dcd62a8ebaf2b756cec26d5 
>   src/main/java/org/apache/aurora/scheduler/spi/Permissions.java 
> c2919ab2b3dca3e3f8fcd095493816ad9b160d46 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 1be533b0b33f529eb345c60369bde98052d60100 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> e7be8e2198564a1d47a6b5121d7ad653db740fdc 
>   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 
> 8f1ee7d91b1dd529de85cf393ec1809b775fa3bb 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  14b5a00dea1a739b2b52e2e1b3b48eb987744760 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java 
> a329b078d18a0db7d2de5484ca79e3c703d5232e 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java
>  9ad9012b81db56c38e3a253dfce06622eae57690 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 2bca8bf4f31c19c1cc797959db4017efbfd8badb 
> 
> Diff: https://reviews.apache.org/r/39095/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39095/#review101788
---

Ship it!


Ship It!

- Maxim Khutornenko


On Oct. 7, 2015, 4:50 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39095/
> ---
> 
> (Updated Oct. 7, 2015, 4:50 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Gradle 2.7 was recently released [1].  It doesn't seem to add a whole lot for 
> us, but it does fix an impedance mismatch with recent versions of checkstyle. 
>  I've also upgraded to the latest checkstyle, which has significant changes 
> of interest, mostly around better lambda handling.  The code changes in this 
> diff are the result of improvements to the default 'redundant modifier' 
> check, and are legitimate.
> 
> [1] https://docs.gradle.org/2.7/release-notes
> [2] http://checkstyle.sourceforge.net/releasenotes.html
> 
> 
> Diffs
> -
> 
>   build.gradle 0401a9cbf0caf5578ef3c30e67c5b6a0a7a74a03 
>   buildSrc/gradle.properties bbfdeb20161f497775e36c4b144436253c37c9f0 
>   gradle/wrapper/gradle-wrapper.properties 
> 6475df2e93744193a635a22080d6c35a1523f4ea 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 
> 712876e1fe2bfb02cb147cd7674a84dd220de899 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 
> 9726a09f7a635bb137473a0ad0cc5ee6db77e6de 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
> cf1b91907fefb3b22dcd62a8ebaf2b756cec26d5 
>   src/main/java/org/apache/aurora/scheduler/spi/Permissions.java 
> c2919ab2b3dca3e3f8fcd095493816ad9b160d46 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 1be533b0b33f529eb345c60369bde98052d60100 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> e7be8e2198564a1d47a6b5121d7ad653db740fdc 
>   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 
> 8f1ee7d91b1dd529de85cf393ec1809b775fa3bb 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  14b5a00dea1a739b2b52e2e1b3b48eb987744760 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java 
> a329b078d18a0db7d2de5484ca79e3c703d5232e 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java
>  9ad9012b81db56c38e3a253dfce06622eae57690 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 2bca8bf4f31c19c1cc797959db4017efbfd8badb 
> 
> Diff: https://reviews.apache.org/r/39095/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>