Re: Review Request 39572: Remove callable check.

2015-10-22 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39572/#review103691
---


Master (2f173c6) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 22, 2015, 11:42 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39572/
> ---
> 
> (Updated Oct. 22, 2015, 11:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1524
> https://issues.apache.org/jira/browse/AURORA-1524
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove callable check.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 07a2730a0d4221cd989e85e40daf117a2da16cb4 
> 
> Diff: https://reviews.apache.org/r/39572/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>



Re: Review Request 39572: Remove callable check.

2015-10-22 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39572/#review103689
---

Ship it!


Ship It!

- Joshua Cohen


On Oct. 22, 2015, 11:42 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39572/
> ---
> 
> (Updated Oct. 22, 2015, 11:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1524
> https://issues.apache.org/jira/browse/AURORA-1524
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove callable check.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 07a2730a0d4221cd989e85e40daf117a2da16cb4 
> 
> Diff: https://reviews.apache.org/r/39572/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>



Re: Review Request 39572: Remove callable check.

2015-10-22 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39572/#review103688
---

Ship it!


Ship It!

- Zameer Manji


On Oct. 22, 2015, 4:42 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39572/
> ---
> 
> (Updated Oct. 22, 2015, 4:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1524
> https://issues.apache.org/jira/browse/AURORA-1524
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove callable check.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 07a2730a0d4221cd989e85e40daf117a2da16cb4 
> 
> Diff: https://reviews.apache.org/r/39572/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>