Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104471 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 29, 2015, 8:44

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104473 --- Ship it! Ship It! - Bill Farner On Oct. 29, 2015, 1:44 p.m.,

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/ --- (Updated Oct. 29, 2015, 1:44 p.m.) Review request for Aurora, Maxim

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-29 Thread Zameer Manji
> On Oct. 28, 2015, 8:02 a.m., Bill Farner wrote: > > It's not clear to me is why you didn't decide to return an immutable > > multimap copy and stay behind the previous interface. (Based on the > > typical characteristics of the map, and the way it's used here i don't > > imagine a big perf

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104295 --- Ship it! It's not clear to me is why you didn't decide to return

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/ --- (Updated Oct. 27, 2015, 9:14 p.m.) Review request for Aurora, Maxim

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/ --- (Updated Oct. 27, 2015, 9:12 p.m.) Review request for Aurora, Maxim