Re: Review Request 40042: Adding build target to build kerberos auth module.

2015-11-06 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40042/#review105548
---


Master (745869c) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 7, 2015, 12:17 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40042/
> ---
> 
> (Updated Nov. 7, 2015, 12:17 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Module should have its own target independent of binary bundling.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/kerberos/BUILD 
> 44eda139f584b77c8a4d61dca90cc2027f6a6f66 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> 6d3ade4baf06530e6e0b451e9e20e63fd3203ca0 
> 
> Diff: https://reviews.apache.org/r/40042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 40042: Adding build target to build kerberos auth module.

2015-11-06 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40042/#review105545
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 6, 2015, 4:17 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40042/
> ---
> 
> (Updated Nov. 6, 2015, 4:17 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Module should have its own target independent of binary bundling.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/kerberos/BUILD 
> 44eda139f584b77c8a4d61dca90cc2027f6a6f66 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> 6d3ade4baf06530e6e0b451e9e20e63fd3203ca0 
> 
> Diff: https://reviews.apache.org/r/40042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>